Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small housekeeping items? (Documentation and console.log) #25

Closed
philberry-bb opened this issue Jul 23, 2015 · 2 comments
Closed

Small housekeeping items? (Documentation and console.log) #25

philberry-bb opened this issue Jul 23, 2015 · 2 comments

Comments

@philberry-bb
Copy link

Love the component. Two small things:

Documentation Update

The readme usage says to use the following:

  • <DateRangePicker startDate="1/1/2014" endDate="3/1/2014">

I found I had to use this instead:

  • <DateRangePicker startDate={moment("2014-04-23T09:54:51")} endDate={moment("2014-08-23T09:54:51")}>

Index.js Has The Following Line

  • console.log(this.$picker.data('daterangepicker'));

Was that perhaps left over from development?

@skratchdot
Copy link
Owner

Yes. Sorry about the console.log(). Not sure how that got in there. Definitely a mistake.

@skratchdot
Copy link
Owner

I updated the README w/ the correct moment() documentation. Thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants