Add sinon codemod #242
Merged
Add sinon codemod #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lencioni
approved these changes
Apr 6, 2022
|
This is awesome. Would you mind updating the README. I also believe we have a warning if we see sinon mocks, that should be changed to suggest using the transformer. Depending on the stability of it we might consider including it as a default transformer. |
|
@skovhus updated both README + warning |
skovhus
reviewed
Apr 11, 2022
| @@ -10,7 +10,8 @@ Codemods that simplify migrating JavaScript and TypeScript test files from | |||
| [Mocha](https://github.com/mochajs/mocha), | |||
| [proxyquire](https://github.com/thlorenz/proxyquire), | |||
| [Should.js](https://github.com/tj/should.js/), | |||
| [Tape](https://github.com/substack/tape) | |||
| [Tape](https://github.com/substack/tape), | |||
| [Sinon](https://github.com/sinonjs/), | |||
There was a problem hiding this comment.
Can you also update the “ Usage (jscodeshift)” section?
we should also add sinon to the cli. Let me know if you need any help doing that. :)
skovhus
approved these changes
Apr 11, 2022
|
+1 Great stuff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first pass at a sinon codemod - see relevant thread. We've used this on our codebase to help migrate ~80% (1800+ files) of sinon use cases.
Thanks to @jordalgo for the initial POC.
cc @lencioni @danbeam