Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: API formatting inconsistency #621

Open
b-rowan opened this issue Jan 6, 2025 · 0 comments · May be fixed by #667
Open

bug: API formatting inconsistency #621

b-rowan opened this issue Jan 6, 2025 · 0 comments · May be fixed by #667
Assignees
@WantClue
Labels
accepted This issue will be worked on bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@b-rowan
Copy link
Contributor

b-rowan commented Jan 6, 2025

In http_server.c, there is one key being added to the API JSON which does not match the others. overheat_mode should be changed to overheatMode to match the format of other parts of the API.

ESP-Miner/main/http_server/http_server.c

Line 430 in 39a4c41

cJSON_AddNumberToObject(root, "overheat_mode", nvs_config_get_u16(NVS_CONFIG_OVERHEAT_MODE, 0));

Is there a procedure for deprecating this from the API, in case someone is using it, so that it can be changed?
@WantClue WantClue added the accepted This issue will be worked on label Jan 11, 2025
@WantClue WantClue self-assigned this Jan 11, 2025
@skot skot added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 14, 2025
@0xf0xx0 0xf0xx0 linked a pull request Jan 18, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WantClue WantClue

Labels
accepted This issue will be worked on bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

api formatting consistency 0xf0xx0/ESP-Miner
3 participants
@skot @WantClue @b-rowan