Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorization Code Verification Request is malformed #20

Closed
fluffy-critter opened this issue Oct 30, 2019 · 4 comments
Closed

Authorization Code Verification Request is malformed #20

fluffy-critter opened this issue Oct 30, 2019 · 4 comments

Comments

@fluffy-critter
Copy link

At this point in the spec: https://github.com/sknebel/AutoAuth/blob/master/AutoAuth.md#authorization-code-verification-request

There seem to be two errors, relative to what IndieAuth providers expect:

  • callback_url should be redirect_uri
  • client_id is required

This is at least the case on all of the IndieAuth endpoints I've tried against (namely SelfAuth and commentpara.de).

@sknebel
Copy link
Owner

sknebel commented Oct 30, 2019

This needs to verify the data included in the Token request. there is no redirect_url due to the lack of a a browser in the flow for which this would be appropriate, so no redirect_uri can be checked here.

Client ID could be added if there's good reasons to do so, but I'm not sure it's needed.

@fluffy-critter
Copy link
Author

Does this require the addition of callback_url to IndieAuth authorization endpoints, then? I was under the impression that this specification was intended to work with the existing IndieAuth infrastructure.

@fluffy-critter
Copy link
Author

For reference, I use SelfAuth as my auth_endpoint, with its source at https://github.com/Inklings-io/selfauth/blob/master/index.php
and here's the token_endpoint built into Publ: https://github.com/PlaidWeb/Publ/blob/f1baa08baa2e1bc7cf771b35ec457fc3784f7aea/publ/tokens.py#L22

@fluffy-critter
Copy link
Author

Resolved via discussion, tl;dr form starts at https://chat.indieweb.org/dev/2019-10-30#t1572457299643200 - will continue discussion in #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants