Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personalizations passed as dictionaries cause AssertionErrors #113

Closed
alichass opened this issue Dec 21, 2022 · 2 comments
Closed

Personalizations passed as dictionaries cause AssertionErrors #113

alichass opened this issue Dec 21, 2022 · 2 comments

Comments

@alichass
Copy link
Contributor

Not sure if this is only happening on python 3.10 and above, but the culprit seems to be the type check on line 444 in mail.py: type(personalization) == Dict seems to evaluate to false even when the personalization instances.
I believe replacing the check with isinstance(personalization, Dict) should do the trick and leave things backwards compatible.
(maybe its worth doing this for line 447 as well?)

Let me know if it would be helpful for me to make the changes and create a PR.
Thanks!

@sklarsa
Copy link
Owner

sklarsa commented Dec 21, 2022

Thank you for tracking this down! A PR would be fantastic if you have time

@sklarsa
Copy link
Owner

sklarsa commented Dec 22, 2022

closed by #114

@sklarsa sklarsa closed this as completed Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants