Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not properly clearing the screen when --height is set #494

Open
leo-arch opened this issue Nov 9, 2022 · 5 comments
Open

Not properly clearing the screen when --height is set #494

leo-arch opened this issue Nov 9, 2022 · 5 comments

Comments

@leo-arch
Copy link

leo-arch commented Nov 9, 2022

Issue: As the tittle says, skim isn't properly clearing the screen at exit (abort) whenever --height is set (the screen isn't cleared at all in fact).

Expected behavior: clear the screen, just as it is done when --height isn't set (full screen).

Steps to reproduce:

ls | sk --height=20

Thank you very much in advance.

Update: Same thing with accept.
This happens at least with version 0.10.1. Not there in 0.9.4.

@paoloschi
Copy link

just like that, I am also experiencing the same regression

@timvisee
Copy link

timvisee commented Jan 5, 2023

I'm seeing the same issue. Removing the height parameter fixed this.

@liangkarl
Copy link

I have checked v0.10.4. This issue still happens.
In some terminal emulators, this issue even made skim unusable since the TUI would be messed up.

@airelil
Copy link

airelil commented Oct 24, 2023

@liangkarl , it seems that using the --no-clear-start option helps here. A bit counter-intuitive to me though.
Peek 2023-10-24 18-32-skim

@dvaerum
Copy link

dvaerum commented Oct 29, 2024

@liangkarl , it seems that using the --no-clear-start option helps here. A bit counter-intuitive to me though.

Thanks, that help me track down what I need to do in my own wrapper 😁
https://docs.rs/skim/0.10.4/skim/prelude/struct.SkimOptionsBuilder.html#method.no_clear_start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants