fix bg rAF #70
Merged
fix bg rAF #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ater on continued, diff factor could increase above 1 and thus animation would be quite weird (approached target value from other direction)
|
Hah, what a find. Managed to reproduce it: https://www.dropbox.com/s/v4g23zghw9ghohv/weird-drag.mov?dl=0 – It does correct its position once resumed, but still acts weird indeed. Merged! 🔨 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when rAF is paused (e.g. browser tab is put to background) and then later on continued, diff factor could increase above 1 and thus animation would be quite weird (approached target value from other direction)