Startdrag stopdrag callbacks #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Can you please write two tests for the added functionality? Here are some examples: |
|
I've added the tests, thanks for your hints! |
|
Good stuff 🎩 – Thanks for your contribution! |
flosell
added a commit
to flosell/dragdealer
that referenced
this pull request
Feb 2, 2015
flosell
added a commit
to flosell/dragdealer
that referenced
this pull request
Feb 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
for my use case of dragdealer I need explicit drag start and drag stop callbacks (there's already a target callback, but it is also triggered when the target value is set programmatically via
setValue()).I would be quite happy if you could add them.
By the way, thank you for your work!