Horizontal drag control breaks vertical content scrolling on touch devices #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovidiuch
added a commit
that referenced
this pull request
Jan 16, 2014
ovidiuch
added a commit
that referenced
this pull request
Jan 16, 2014
ovidiuch
added a commit
that referenced
this pull request
Jan 16, 2014
|
Hi @w0rm, I am aware of this issue, it has been raised before. It's kind of sensitive since it involves different behavior between desktop and mobile events. While I won't merge it in master yet because it doesn't have tests and I haven't thought enough about it, I started a branch for this issue and managed to solve it. Please try it out and let me know if it works how you expect it. Source here: https://raw.github.com/skidding/dragdealer/3f31152ef0acf8e25b0b5d69fcaba6439c9b56c5/src/dragdealer.js |
|
@skidding Thanks! I've just updated it on my website and it seems to work as expected. |
ovidiuch
added a commit
that referenced
this pull request
Jan 22, 2014
Merged
ovidiuch
added a commit
that referenced
this pull request
Jan 22, 2014
ovidiuch
added a commit
that referenced
this pull request
Jan 22, 2014
ghost
assigned
ovidiuch
added a commit
that referenced
this pull request
Jan 23, 2014
ovidiuch
added a commit
that referenced
this pull request
Jan 23, 2014
ovidiuch
added a commit
that referenced
this pull request
Jan 23, 2014
ovidiuch
added a commit
that referenced
this pull request
Jan 23, 2014
ovidiuch
added a commit
that referenced
this pull request
Jan 23, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'd like to thank you for this plugin, I've been a huge fan of it since the first release and used it in a couple of projects!
I used two dragdealers to implement image gallery (http://en.cafe.nov.ru/briosh) and ran into problem on touch screen devices where it breaks vertical scrolling of the page. I've just checked demo of the new version, and I'm still unable to scroll the page after I tap on dragdealer. It's a huge usability concern that would be nice to solve.