Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use video thumbnail sizes for video #1519

Open
marekdedic opened this issue Jul 20, 2022 · 0 comments
Open

Use video thumbnail sizes for video #1519

marekdedic opened this issue Jul 20, 2022 · 0 comments

Comments

@marekdedic
Copy link
Contributor

When video sizes are not present in the API response, they're set to 0 and left for the browser to figure out after loading (which it does). Instead, we could maybe use the thumbnail sizes.

'width' => array_key_exists( 'videoMediaMetadata', $video ) && array_key_exists( 'width', $video['videoMediaMetadata'] ) ? $video['videoMediaMetadata']['width'] : '0',
'height' => array_key_exists( 'videoMediaMetadata', $video ) && array_key_exists( 'height', $video['videoMediaMetadata'] ) ? $video['videoMediaMetadata']['height'] : '0',

@marekdedic marekdedic added this to the To be determined milestone Jul 20, 2022
@marekdedic marekdedic modified the milestones: To be determined, Version 2.X Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant