Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Did not handle one Norwegian letter correctly #1

Closed
large opened this issue Apr 9, 2018 · 3 comments
Closed

Did not handle one Norwegian letter correctly #1

large opened this issue Apr 9, 2018 · 3 comments
Labels

Comments

@large
Copy link

large commented Apr 9, 2018

Hi! Thank you for a great class!
Simple quick and it has been working fine for me.

One user though responded that his name had changed from "Øystein" to "Oystein", and when I tested it it translated "Øø" to "Oo" in the Strings.Decrypt function.

Other special norwegian letters like ÆÅ or æå works just fine 👍

Is this a known issue? If not any suggestion to work around it?

@sjh37
Copy link
Owner

sjh37 commented Apr 9, 2018

Hi. I think this is down to using UTF8 and not Unicode

e.g.

var input = Encoding.UTF8.GetBytes(data + sharedKey);

instead of

var input = Encoding.Unicode.GetBytes(data + sharedKey);

Change all UTF8 to be Unicode and let me know if this works for you.

@sjh37 sjh37 added the bug label Apr 9, 2018
@sjh37
Copy link
Owner

sjh37 commented Apr 9, 2018

This has now been fixed. Can you please test with v3.0.1.
This is now using Unicode instead of UTF8, so the semantic version has been increased to show incompatibility with v2 hashes.

@large
Copy link
Author

large commented Apr 9, 2018

Wow, that was quick fixed 👍
Works like a charm in 3.0.1, good work!

@sjh37 sjh37 closed this as completed Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants