Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor how we show Sync/Settings #1264

Closed
rbosker opened this issue Sep 7, 2022 · 3 comments · Fixed by #1453
Closed

Refactor how we show Sync/Settings #1264

rbosker opened this issue Sep 7, 2022 · 3 comments · Fixed by #1453
Assignees
@swordEdge
Labels
sync indicators

Comments

@rbosker
Copy link
Collaborator

rbosker commented Sep 7, 2022 •
edited by six7
Loading

Description

The current Sync experience is poor as it grew drastically over the last couple of months with new providers that were added.

Requirements

We should refactor this:

  • Don't group sync settings by provider
  • Instead, show all stored providers in a vertical list
  • Add a Add new button that lets the user choose from Providers
  • After choosing one, do the same thing as we did today.
  • Change each Sync Item so we have a ... menu that shows more options
  • Show Connection errors inside the active sync item if there is one

Image
Image

image
@rbosker rbosker assigned rbosker and unassigned rbosker Sep 7, 2022
@rbosker rbosker mentioned this issue Sep 7, 2022
Closed
28 tasks
@rbosker
Copy link
Collaborator Author

rbosker commented Sep 8, 2022

include validation > @rbosker check the issue for the error handling.

@swordEdge swordEdge self-assigned this Nov 23, 2022
@esthercheran
Copy link
Collaborator

All the sync providers are showing the same icon.

Image

In light mode, the dropdown menu on 'Add new' is still in dark mode.

Image

@swordEdge swordEdge linked a pull request Nov 28, 2022 that will close this issue
1264 refactor how we show syncsettings #1453
Merged
@six7 six7 moved this to 🤞 To be released in Tokens Studio for Figma Roadmap Dec 10, 2022
@six7
Copy link
Collaborator

six7 commented Dec 31, 2022

Shipped in 129

@six7 six7 closed this as completed Dec 31, 2022
@github-project-automation github-project-automation bot moved this from 🤞 To be released to 🕜 In Progress in Tokens Studio for Figma Roadmap Dec 31, 2022
@six7 six7 moved this from 🕜 In Progress to ✅ Done in Tokens Studio for Figma Roadmap Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swordEdge swordEdge

Labels
sync indicators
Projects
Tokens Studio for Figma Roadmap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1264 refactor how we show syncsettings tokens-studio/figma-plugin
5 participants
@six7 @swordEdge @esthercheran @MightyDevKnight @rbosker