-
-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm error while installing #2483
Comments
Hi @MaksSieve thanks for creating the issue. It seems to fail with the unpack. I think this shouldn't be a specific issue but need to look into it. Any help appreciated since I don't have a Windows machine. Best |
@soulgalore Same issue here, inside official node docker image based on debian:
Issue occurs since [email protected]. Fix: downgrading to [email protected] fixes this issue. |
Hi @drptbl ah thanks for sharing, let me try reproduce then. Not sure right now though why it started to happen in 9.1. Best |
Did some searching it seems like a problem that pops up for Yarn now and then, see yarnpkg/yarn#1834 The original problem why we have a hacked version of Selenium could be fixed: The NodeJS version released the alpha of Selenium 4 2018-01-13. That version is broken, I've made an upstream issue because it was broken when refactoring and I think the maintainer that broke it should fix it. So I branched the current 3.6 and added two new methods to talk to the devtools protocol for Chrome. That's why we have our own version. However: someparts in Chromedriver (that Selenium uses) is broken. When you get the trace log from Chrome, it doesn't use the "stop" command that says wait for all the traces that is needed for the navigation. So we also introduced another way of talking to CDP. So ... hehe ... I think since both npm and yarn sometimes has problem with getting the files correctly, we should just switch to the old 3.6 and then at the same time convert how we talk to the CDP inside of Browsertime to avoid using Selenium for that part. Yep that is probably the best longtime solution. I need to look into the code and see how much work that is. |
@soulgalore thanks a lot for looking in to this and for explanation. Best Regards, |
I had a quick look, if everything works out, I'll release a fix on Saturday morning :) |
@soulgalore thanks a lot for fast fix! everything works on Windows Ubuntu Subsytem! |
@soulgalore but is there any way to run sitespeed on OS without gui? |
@MaksSieve not sure exactly how you mean? You mean headless? If you use the npm version you can add --headless and it will work. However then you will not get any video or video metrics. If you setup XVFB you can run "headless". The Docker version do that automatically. |
I just released 9.2.1 that should fix this. |
@soulgalore Just tested, everything works as expected in 9.2.1. Thanks for fast fix 🙂. I think this issue can be closed now (OP also verified that it's fixed). Best Regards, |
Great! |
I tried to install sitespeed to Mircosoft Ubuntu but has thi problem
The text was updated successfully, but these errors were encountered: