Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close dialog when bookmarked is saved #13

Open
rbauduin opened this issue Jan 9, 2022 · 0 comments · May be fixed by #65
Open

close dialog when bookmarked is saved #13

rbauduin opened this issue Jan 9, 2022 · 0 comments · May be fixed by #65

Comments

@rbauduin
Copy link

rbauduin commented Jan 9, 2022

Currently, the dialog displays "Bookmark saved" without closing, though no action is available anymore (the save button is not displayed anymore, and pressnig enter in a field doesn't send an updated bookmark to the backend).

Linkding is great, thanks for it!
@Q3x7Dvh Q3x7Dvh mentioned this issue May 8, 2023
Closed
@jonathan-s jonathan-s linked a pull request Jan 20, 2024 that will close this issue
Open
AdamVig added a commit to AdamVig/linkding-extension that referenced this issue Dec 6, 2024
@AdamVig
Allow updating bookmark immediately after save
e6fb518 
Currently, after saving a bookmark, there is no way to submit updates
without closing the extension dialog and reopening it. This makes it
possible to submit updates to the bookmark without reopening the
extension.

Also:
- Shows the star badge on the extension icon immediately after a
successful save
- Displays the "This URL is already bookmarked." message after the
save success state resets

Similar to the logic in the closed pull request sissbruecker#46. May resolve sissbruecker#13.
@AdamVig AdamVig mentioned this issue Dec 6, 2024
Open
AdamVig added a commit to AdamVig/linkding-extension that referenced this issue Dec 6, 2024
@AdamVig
Allow updating bookmark immediately after save
d385319 
Currently, after saving a bookmark, there is no way to submit updates
without closing the extension dialog and reopening it. This makes it
possible to submit updates to the bookmark without reopening the
extension.

Also:
- Shows the star badge on the extension icon immediately after a
successful save
- Displays the "This URL is already bookmarked." message after the
save success state resets

Similar to the logic in the closed pull request sissbruecker#46. May address sissbruecker#13.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close pop-up once we have saved the bookmark jonathan-s/linkding-extension
1 participant
@rbauduin