Fix for Bug #73. Now use frequency shifted to frame of cell then averaged #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhmatthews
added a commit
that referenced
this pull request
Mar 21, 2014
Fix for Bug #73. Now use frequency shifted to frame of cell then averaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first initial fix for Bug #73.
We now choose doppler shift the frequency of the photon to the rest frame of the cell in question when calculated the continuum opacities. These opacities are use to work out both the heating contribution and the weight reduction of the photon in question.
Note that as KSL pointed out, this is not the best we can do and we may cross an edge over the frequency difference between the initial position and the initial position + ds. This may want to be improved to have something which checks if an edge has been crossed.