-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version change to py88 #1056
Merged
Version change to py88 #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change flux estimators from x/y/z to r/theta/phi Change flux estimators from x/y/z to r/theta/phi to avoid extra noise added in PLUTO when doing the transformation from x/y/z to r/theta/phi on a coarse grid. * Change flux from x/y/z to r/theta/phi * Remove files put in root directory by mistake. --------- Co-authored-by: Knox S. Long <[email protected]>
…enerate simple data files directly from chianti (#1052) * Retrun to more reliable gsl integration * Fixes for photon in cell w/out wind * Update of inspect_wind * Remove diagnostic line * Update to deal with bug_tardis * Add Ca to windsave2table for 1d sn comparison * Doxygen doc for collisional rates * Update to RedoPhot so can handle non-macro files as well * Sphinx updates explaining #834 Live or die and extract can differ in models where one is extracting along a wind cone. * Clean up issue #963 The issue was that in live or die mode, one cannot with advanced diagnostics, select photon by position. As it is not clear, why one would want to do this, and since it would require effort to fix. The program exits and advises the user to use extract mode instead. * A routine to convert macro to simple atomic models The macro models must have been made with MakeMacro * Fix import.py routines to obtain correct rho Windsave2table reports CMF rho's. Python expects observer frame rho's. This is a simple fix in the import reoutiens to reflect this. See Issue #787 * Change version to 87i * Change of ion mode for balmer test
Turn off upweighting of simple atoms in indivisible ("macro-atom") line transfer mode
Don't record Compton heating as a contributor to kpkt_abs
# Conflicts: # rad_hydro_files.c # source/estimators_simple.c # source/macro_gen_f.c # source/para_update.c # source/python.h # source/wind_updates2d.c
# Conflicts: # source/import_spherical.c
This merge encapsulates all of the changes that occurred in the various versions of py87. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply closes out py87 all versions, with change in version to py88