Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in mode 8 of bands init #157

Closed
Higginbottom opened this issue Jul 2, 2015 · 0 comments
Closed

Bug in mode 8 of bands init #157

Higginbottom opened this issue Jul 2, 2015 · 0 comments

Comments

@Higginbottom
Copy link
Collaborator

Mode 8 is the automatic log spaced bands for photon generation.
The lines which work out the depicting of the bands are

f1_log = log10 (f1);
f2_log = log10 (f2);
df = (f2_log - f1_log) / (band->nbands + 1);

but df should be divided by nbands not nbands+1

e.g. if we want 5 bands to run from 0 to 10, clearly each band must be 2 wide, but (10-0)/5+1 does not equal 2! This was causing the final band to be missed off - a lot of frequencies in log space!

I will correct, and submit a pull request.

Higginbottom added a commit to Higginbottom/python that referenced this issue Jul 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant