perf session: Add missing evlist__delete when deleting a session

commit cf96b8e upstream.

ASan reports a memory leak caused by evlist not being deleted on exit in
perf-report, perf-script and perf-data.
The problem is caused by evlist->session not being deleted, which is
allocated in perf_session__read_header, called in perf_session__new if
perf_data is in read mode.
In case of write mode, the session->evlist is filled by the caller.
This patch solves the problem by calling evlist__delete in
perf_session__delete if perf_data is in read mode.

Changes in v2:
 - call evlist__delete from within perf_session__delete

v1: https://lore.kernel.org/lkml/[email protected]/

ASan report follows:

$ ./perf script report flamegraph
=================================================================
==227640==ERROR: LeakSanitizer: detected memory leaks

<SNIP unrelated>

Indirect leak of 2704 byte(s) in 1 object(s) allocated from:
    #0 0x4f4137 in calloc (/home/user/linux/tools/perf/perf+0x4f4137)
    gregkh#1 0xbe3d56 in zalloc /home/user/linux/tools/lib/perf/../../lib/zalloc.c:8:9
    gregkh#2 0x7f999e in evlist__new /home/user/linux/tools/perf/util/evlist.c:77:26
    gregkh#3 0x8ad938 in perf_session__read_header /home/user/linux/tools/perf/util/header.c:3797:20
    gregkh#4 0x8ec714 in perf_session__open /home/user/linux/tools/perf/util/session.c:109:6
    gregkh#5 0x8ebe83 in perf_session__new /home/user/linux/tools/perf/util/session.c:213:10
    gregkh#6 0x60c6de in cmd_script /home/user/linux/tools/perf/builtin-script.c:3856:12
    gregkh#7 0x7b2930 in run_builtin /home/user/linux/tools/perf/perf.c:313:11
    gregkh#8 0x7b120f in handle_internal_command /home/user/linux/tools/perf/perf.c:365:8
    gregkh#9 0x7b2493 in run_argv /home/user/linux/tools/perf/perf.c:409:2
    gregkh#10 0x7b0c89 in main /home/user/linux/tools/perf/perf.c:539:3
    gregkh#11 0x7f5260654b74  (/lib64/libc.so.6+0x27b74)

Indirect leak of 568 byte(s) in 1 object(s) allocated from:
    #0 0x4f4137 in calloc (/home/user/linux/tools/perf/perf+0x4f4137)
    gregkh#1 0xbe3d56 in zalloc /home/user/linux/tools/lib/perf/../../lib/zalloc.c:8:9
    gregkh#2 0x80ce88 in evsel__new_idx /home/user/linux/tools/perf/util/evsel.c:268:24
    gregkh#3 0x8aed93 in evsel__new /home/user/linux/tools/perf/util/evsel.h:210:9
    gregkh#4 0x8ae07e in perf_session__read_header /home/user/linux/tools/perf/util/header.c:3853:11
    gregkh#5 0x8ec714 in perf_session__open /home/user/linux/tools/perf/util/session.c:109:6
    gregkh#6 0x8ebe83 in perf_session__new /home/user/linux/tools/perf/util/session.c:213:10
    gregkh#7 0x60c6de in cmd_script /home/user/linux/tools/perf/builtin-script.c:3856:12
    gregkh#8 0x7b2930 in run_builtin /home/user/linux/tools/perf/perf.c:313:11
    gregkh#9 0x7b120f in handle_internal_command /home/user/linux/tools/perf/perf.c:365:8
    gregkh#10 0x7b2493 in run_argv /home/user/linux/tools/perf/perf.c:409:2
    gregkh#11 0x7b0c89 in main /home/user/linux/tools/perf/perf.c:539:3
    gregkh#12 0x7f5260654b74  (/lib64/libc.so.6+0x27b74)

Indirect leak of 264 byte(s) in 1 object(s) allocated from:
    #0 0x4f4137 in calloc (/home/user/linux/tools/perf/perf+0x4f4137)
    gregkh#1 0xbe3d56 in zalloc /home/user/linux/tools/lib/perf/../../lib/zalloc.c:8:9
    gregkh#2 0xbe3e70 in xyarray__new /home/user/linux/tools/lib/perf/xyarray.c:10:23
    gregkh#3 0xbd7754 in perf_evsel__alloc_id /home/user/linux/tools/lib/perf/evsel.c:361:21
    gregkh#4 0x8ae201 in perf_session__read_header /home/user/linux/tools/perf/util/header.c:3871:7
    gregkh#5 0x8ec714 in perf_session__open /home/user/linux/tools/perf/util/session.c:109:6
    gregkh#6 0x8ebe83 in perf_session__new /home/user/linux/tools/perf/util/session.c:213:10
    gregkh#7 0x60c6de in cmd_script /home/user/linux/tools/perf/builtin-script.c:3856:12
    gregkh#8 0x7b2930 in run_builtin /home/user/linux/tools/perf/perf.c:313:11
    gregkh#9 0x7b120f in handle_internal_command /home/user/linux/tools/perf/perf.c:365:8
    gregkh#10 0x7b2493 in run_argv /home/user/linux/tools/perf/perf.c:409:2
    gregkh#11 0x7b0c89 in main /home/user/linux/tools/perf/perf.c:539:3
    gregkh#12 0x7f5260654b74  (/lib64/libc.so.6+0x27b74)

Indirect leak of 32 byte(s) in 1 object(s) allocated from:
    #0 0x4f4137 in calloc (/home/user/linux/tools/perf/perf+0x4f4137)
    gregkh#1 0xbe3d56 in zalloc /home/user/linux/tools/lib/perf/../../lib/zalloc.c:8:9
    gregkh#2 0xbd77e0 in perf_evsel__alloc_id /home/user/linux/tools/lib/perf/evsel.c:365:14
    gregkh#3 0x8ae201 in perf_session__read_header /home/user/linux/tools/perf/util/header.c:3871:7
    gregkh#4 0x8ec714 in perf_session__open /home/user/linux/tools/perf/util/session.c:109:6
    gregkh#5 0x8ebe83 in perf_session__new /home/user/linux/tools/perf/util/session.c:213:10
    gregkh#6 0x60c6de in cmd_script /home/user/linux/tools/perf/builtin-script.c:3856:12
    gregkh#7 0x7b2930 in run_builtin /home/user/linux/tools/perf/perf.c:313:11
    gregkh#8 0x7b120f in handle_internal_command /home/user/linux/tools/perf/perf.c:365:8
    gregkh#9 0x7b2493 in run_argv /home/user/linux/tools/perf/perf.c:409:2
    gregkh#10 0x7b0c89 in main /home/user/linux/tools/perf/perf.c:539:3
    gregkh#11 0x7f5260654b74  (/lib64/libc.so.6+0x27b74)

Indirect leak of 7 byte(s) in 1 object(s) allocated from:
    #0 0x4b8207 in strdup (/home/user/linux/tools/perf/perf+0x4b8207)
    gregkh#1 0x8b4459 in evlist__set_event_name /home/user/linux/tools/perf/util/header.c:2292:16
    gregkh#2 0x89d862 in process_event_desc /home/user/linux/tools/perf/util/header.c:2313:3
    gregkh#3 0x8af319 in perf_file_section__process /home/user/linux/tools/perf/util/header.c:3651:9
    gregkh#4 0x8aa6e9 in perf_header__process_sections /home/user/linux/tools/perf/util/header.c:3427:9
    gregkh#5 0x8ae3e7 in perf_session__read_header /home/user/linux/tools/perf/util/header.c:3886:2
    gregkh#6 0x8ec714 in perf_session__open /home/user/linux/tools/perf/util/session.c:109:6
    gregkh#7 0x8ebe83 in perf_session__new /home/user/linux/tools/perf/util/session.c:213:10
    gregkh#8 0x60c6de in cmd_script /home/user/linux/tools/perf/builtin-script.c:3856:12
    gregkh#9 0x7b2930 in run_builtin /home/user/linux/tools/perf/perf.c:313:11
    gregkh#10 0x7b120f in handle_internal_command /home/user/linux/tools/perf/perf.c:365:8
    gregkh#11 0x7b2493 in run_argv /home/user/linux/tools/perf/perf.c:409:2
    gregkh#12 0x7b0c89 in main /home/user/linux/tools/perf/perf.c:539:3
    gregkh#13 0x7f5260654b74  (/lib64/libc.so.6+0x27b74)

SUMMARY: AddressSanitizer: 3728 byte(s) leaked in 7 allocation(s).

Signed-off-by: Riccardo Mancini <[email protected]>
Acked-by: Ian Rogers <[email protected]>
Acked-by: Jiri Olsa <[email protected]>
Cc: Adrian Hunter <[email protected]>
Cc: Alexander Shishkin <[email protected]>
Cc: Ian Rogers <[email protected]>
Cc: Kan Liang <[email protected]>
Cc: Leo Yan <[email protected]>
Cc: Mark Rutland <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: http://lore.kernel.org/lkml/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Cc: [email protected] # 5.10.228
Signed-off-by: Shuai Xue <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

tools/perf/util/session.c

@@ -299,8 +299,11 @@ void perf_session__delete(struct perf_session *session)
 	perf_session__release_decomp_events(session);
 	perf_env__exit(&session->header.env);
 	machines__exit(&session->machines);
-	if (session->data)
+	if (session->data) {
+		if (perf_data__is_read(session->data))
+			evlist__delete(session->evlist);
 		perf_data__close(session->data);
+	}
 	free(session);
 }