Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master is broken due to depset changes #403

Closed
celskeggs opened this issue Jun 8, 2019 · 1 comment
Closed

Master is broken due to depset changes #403

celskeggs opened this issue Jun 8, 2019 · 1 comment

Comments

@celskeggs
Copy link
Member

celskeggs commented Jun 8, 2019

ERROR: /homeworld/platform/spire/BUILD.bazel:28:1: in zip_file rule //spire:spirezip: 
Traceback (most recent call last):
	File "/homeworld/platform/spire/BUILD.bazel", line 28
		zip_file(name = 'spirezip')
	File "/homeworld/platform/bazel/zip_file.bzl", line 168, in _zip_file
		srcs += ctx.files.srcs
`+` operator on a depset is forbidden. See https://docs.bazel.build/versions/master/skylark/depsets.html for recommendations. Use --incompatible_depset_union=false to temporarily disable this check.
ERROR: Analysis of target '//upload:upload' failed; build aborted: Analysis of target '//spire:spirezip' failed; build aborted

We should get a newer version of the zip_file implementation that solves this, if one is available, or otherwise patch zip_file.bzl to be compatible with these recent changes. Also, #378 is ever-relevant.

@celskeggs
Copy link
Member Author

Master is fixed. This is now just part of upgrading bazel to latest (see #404, #407).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants