Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amended 1563 #1564

Merged
merged 2 commits into from
Sep 18, 2017
Merged

Amended 1563 #1564

merged 2 commits into from
Sep 18, 2017

Conversation

fatso83
Copy link
Contributor

@fatso83 fatso83 commented Sep 18, 2017

A repack of #1563, just with updated package-lock.json.

Basically removes a dependency added by mistake.

vsa and others added 2 commits September 18, 2017 16:52
@vsa @fatso83
Removes dependency to "build"
37ff38b 
This was added by mistake in version 3.3 as part of commit 85f30b5.
@fatso83
Update deps lock file
cf32e6d
@fatso83 fatso83 mentioned this pull request Sep 18, 2017
Closed
2 tasks
@fatso83 fatso83 merged commit 5ec0ae0 into sinonjs:master Sep 18, 2017
@fatso83 fatso83 deleted the amended-1563 branch September 18, 2017 15:02
@mroderick mroderick mentioned this pull request Sep 20, 2017
Closed
@frank-dspeed
Copy link

@fatso83

─┬ [email protected]
  └─┬ [email protected]
    └── [email protected]

still not solved reopen!

@mroderick
Copy link
Member

@frank-dspeed there is no trace of the build dependency in current master (3837635)

rm -rf node_modules
npm install
npm ls build
[email protected] /Users/morgan/code/sinonjs/sinon
└── (empty)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fatso83 @frank-dspeed @mroderick @vsa