Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for stubbing undefined props #1557

Merged
merged 1 commit into from
Sep 18, 2017
Merged

Commits on Sep 13, 2017

  1. Remove support for stubbing undefined props

    This was a longer discussion that can be found in the
    issues sinonjs#1508, sinonjs#1552 and sinonjs#1537 - and internally amongst the core team.
    
    Support for stubbing props using get()/set() was added in sinonjs#1237
    and also worked for undefined properties.
    
    This type of behavior (stubbing undefined props) has been
    explicitly disabled for sandboxes, so in order for Sinon to
    behave in a consistent way, we should do the same here.
    
    This change will bring normal stubs back to how it has
    used to be historically, and will make sandbox stubs
    and normal sinon stubs behave the same.
    
    It might break things for people relying on the behavior
    that has been present since Sinon 2.0, but it should
    make things more reliable going forward.
    fatso83 committed Sep 13, 2017
    Configuration menu
    Copy the full SHA
    612a9bd View commit details
    Browse the repository at this point in the history