Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to minify when used with create-react-app #1830

Closed
prontiol opened this issue Jun 7, 2018 · 2 comments
Closed

Failed to minify when used with create-react-app #1830

prontiol opened this issue Jun 7, 2018 · 2 comments

Comments

@prontiol
Copy link

prontiol commented Jun 7, 2018

Describe the bug
We use sinon as a part of our application built with create-react-app
After upgrading to v5.1.0 the npm run build command failed with an error:

Failed to minify the code from this file:
./node_modules/sinon/pkg/sinon-esm.js:4824
Read more here: http://bit.ly/2tRViJ9

To Reproduce
Steps to reproduce the behavior:

  1. Create an application with create-react-app
  2. Install [email protected]
  3. Run npm run build
  4. See error

Expected behavior
Build completes successfully

@fatso83
Copy link
Contributor

fatso83 commented Jun 8, 2018

See #1829. Once it's approved this should be good. Be aware that once Sinon 6 ships this will break your build again should you choose to upgrade to that (meaning you need to fix your own build to work with ES2015 modules or disable use of the module keyword entirely in your bundler).

@fatso83
Copy link
Contributor

fatso83 commented Jun 9, 2018

This should be closed now that Sinon 5.1.1 is out and 5.1.0 has been deprecated.

@fatso83 fatso83 closed this as completed Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants