README.md: some corrections and cleanup #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
commented
Mar 6, 2024
| @@ -127,12 +126,12 @@ We get the following table of comparison. | |||
| |degree|[10] => 5465008*q[1]^20 +…|5.453744 s(3.425 GiB)|0.000033 s ( 1.609 KiB)| | |||
|
|
|||
|
|
|||
| simillary for The univariable polynomial, we have | |||
| similarly for The univariable polynomial, we have | |||
There was a problem hiding this comment.
this sentence still is wrong, but I couldn't figure it out what you even meant, so I can't suggest an improvement (well I can guess that "univariable" is supposed to mean "univariate" and "The" -> "the" but the entire sentence still doesn't make sense to me. No need to explain it to me either!! But perhaps think about it and whether you can rephrase it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 90.93% 90.93%
=======================================
Files 8 8
Lines 739 739
=======================================
Hits 672 672
Misses 67 67 ☔ View full report in Codecov by Sentry. |
blociss
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.