Second navigation in same app is always ignored

[kentora]

Demonstration

I have a single-spa setup with a nav-app, app1 and app2. When i click a link for app1 in my nav-app, and then another link for another component in app1 from nav-app the navigation is ignored. This happens consitently, and only for the second navigation.

It seems to be releated to #113 as i can see that upon mounting app1 the first time, replaceState in extra-provider.ts is called, setting the flag skipNextPopState, which then causes the second navigation event to be ignored.

I'm unsure if the fix is needed with newer versions of single-spa, or the root cause has been fixed. I have not had any problems in commenting out the line setting the flag.

Expected Behavior

Navigation occurs

Actual Behavior

Navigation is ignored.

[Arjun99]

Is this happening only for your app1 ? Have you setup emptyroutecomponent in your angular applications?

[kentora]

It seems to be pretty consistent, when navigation occurs within the active app. EmptyRouteComponent is correctly setup.

[Arjun99]

Can you share your layout.html in the root-config file that you have created for the configuring the routes.

[sandeep-dxc]

I have created a repo to reproduce this issue, thanks to @kfrederix for the base repo.

Screen.Recording.2024-11-26.210344.mp4

https://github.com/sandeep-dxc/single-spa-angular-esm

pnpm i
pnpm dev
http://localhost:4300/

@joeldenning @arturovt Would you have any suggestions on how to resolve this.

Thanks.

[Arjun99]

Hi Sandeep,

Let me check that and get back to you.

[kfrederix]

Hello @sandeep-dxc , I took a look at your repo => you can solve this issue by setting urlRerouteOnly to false in the host main.ts. E.g.

start({ urlRerouteOnly: false });

(I will add that also on my repo, because it's usually recommended to do that for Angular applications)

[sandeep-dxc]

Thanks @kfrederix, its working now 👍