From 348217333850941403d57c6a3b06a14397507656 Mon Sep 17 00:00:00 2001 From: John Kerl Date: Wed, 13 Nov 2024 11:49:31 -0500 Subject: [PATCH] code-review feedback [skip ci] Co-authored-by: Julia Dark <24235303+jp-dark@users.noreply.github.com> --- apis/r/src/rinterface.cpp | 2 +- apis/r/src/rutilities.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/apis/r/src/rinterface.cpp b/apis/r/src/rinterface.cpp index 7837177d57..4b23663a90 100644 --- a/apis/r/src/rinterface.cpp +++ b/apis/r/src/rinterface.cpp @@ -404,7 +404,7 @@ SEXP c_schema(const std::string& uri, Rcpp::XPtr ctxxp) { ArrowSchemaAllocateChildren(sch, lib_retval->n_children), "Bad schema children alloc"); - for (size_t i = 0; i < (size_t)lib_retval->n_children; i++) { + for (size_t i = 0; i < static_cast(lib_retval->n_children); i++) { spdl::info( "[c_schema] Accessing name '{}' format '{}' at position {}", std::string(lib_retval->children[i]->name), diff --git a/apis/r/src/rutilities.cpp b/apis/r/src/rutilities.cpp index 357d4a928d..dc3f2e7355 100644 --- a/apis/r/src/rutilities.cpp +++ b/apis/r/src/rutilities.cpp @@ -468,7 +468,7 @@ SEXP convert_domainish(const tdbs::ArrowTable& arrow_table) { ArrowArrayAllocateChildren(arr, arrow_array->n_children), "Bad array children alloc"); - for (size_t i = 0; i < (size_t)ncol; i++) { + for (size_t i = 0; i < static_cast(ncol); i++) { if (arrow_array->children[i]->n_buffers == 3) { // Arrow semantics: variable-length: buffers 0,1,2 are validity, // offsets, data