Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powershell (Get-CimInstance -ClassName Win32_OperatingSystem).caption throws on win 10 pro #27

Open
yann300 opened this issue Sep 9, 2022 · 3 comments

Comments

@yann300
Copy link

yann300 commented Sep 9, 2022

powershell (Get-CimInstance -ClassName Win32_OperatingSystem).caption is throwing an error win 10 pro.
see the screenshot referenced in ethereum/remix-desktop#147
feel free to reach out if you need more information to debug that issue.

Thanks

@aaetera
Copy link

aaetera commented Sep 9, 2022

Seems like my system does not have English language, so output of powershell cmd (Get-CimInstance -ClassName Win32_OperatingSystem).caption is in Unicode. In my point of view, that's what causes an error.

@tabarra
Copy link

tabarra commented Sep 15, 2022

I just got an user with very similar issue but in German.
I translated and it says the command "powershell" is either misspelled or could not be found.
So I guess this is a case of a windows machine without powershell found in any of the PATH binary paths.

https://github.com/sindresorhus/windows-release/blob/main/index.js#L42
Considering the code does not handle cases where the powershell command fails, i think this is the issue.

I recommend renaming this issue to [BUG] The lib does not handle cases where powershell is not available.

@cbartondock
Copy link

Same here

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants