Drop a few dashboard-related changes #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub changed the dashboard style
This comment has been minimized.
This comment has been minimized.
The button appears a bit later, so it can't stop listening to changes as soon as it can't find it
|
|
|
Just noting some of the code being removed here like the account switcher and dashboard sections hiding is one of the first code with which Sindre started Refined GitHub and now GitHub has improved it so we can drop it. It's nice to see it all coming full circle. |
hkdobrev
approved these changes
May 17, 2018
|
This will impact GHE so I'd prefer this to be backwards compatible for
those users for a bit longer.
…On Thu, May 17, 2018, 5:25 PM Haralan Dobrev ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1330 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA0WZKMxeSCENka-hYhw_-1FBnVYSw2Lks5tzfjpgaJpZM4UDxvB>
.
|
busches
reviewed
May 17, 2018
source/content.js
Outdated
| @@ -73,7 +72,6 @@ import addScopedSearchOnUserProfile from './features/add-scoped-search-on-user-p | |||
| import monospaceTextareas from './features/monospace-textareas'; | |||
| import improveShortcutHelp from './features/improve-shortcut-help'; | |||
| import displayIssueSuggestions from './features/display-issue-suggestions'; | |||
| import addPullRequestHotkey from './features/add-pull-request-hotkey'; | |||
There was a problem hiding this comment.
Good catch. I didn’t. It was a bad manual merge
As long as PRs don’t break GHE we can still merge them. You’ll just miss this minor cleanup until your GHE is updated |
|
Maybe leave the move account sidebar for a bit let them at least have that |
|
@yakov116 same answer applies. |
This was referenced Jul 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub changed the dashboard style. Fixes #1331
Native
Current PR