-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide inactive deployments #1144
Labels
Comments
hkdobrev
added
enhancement
help wanted
small
Issues that new contributors can pick up
labels
Mar 7, 2018
@fxedel This sounds right and in line with what we do in similar situations. Could you create a pull request implementing it? Thanks! |
This CSS needs to be placed near the one hiding issue renames |
@hkdobrev Great! I'll try to implement it soon ... |
fxedel
added a commit
to fxedel/refined-github
that referenced
this issue
Mar 8, 2018
hkdobrev
pushed a commit
that referenced
this issue
Mar 22, 2018
* Hide inactive deployments (closes #1144) * Fix lint * Refresh on AJAX reload * Avoid observer loops * Improve observer again * Small fix * Fix attribute * Fix requested changes * Lint: start comment with lowercase char * Fix requested changes * Fix mistake in last commit * Requested changes
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We use continuous deployment with Heroku, and on each push, there's a message like this: "XY deployed to repo-name-pr-123 1 minute ago"
As soon as there's a new deployment, the old message gets replaced with "XY temporarily deployed to ..." as seen below:
(Note: The
Inactive
label isn't even clickable to provide more information)These inactive deployments actually give no information – they're no longer accessible and the information when something was deployed isn't really important. However, the inactive messages annoy me when reading the commit history. I'd really like them to be completely hidden, like so:
The html code for the whole deployment history item is the following:
The important class is
is-inactive
(possible selector:.js-timeline-item .deployment-status-label.is-inactive
): It indicates that this item is inactive and differentiates it from active items. (The stylesheet also mentions these classes:.is-error
,.is-failure
,.is-active
,.is-pending
)I suggest searching for that selector via JavaScript and adding a custom class or data-tag to the containing .js-timeline-item, so that we can select the whole inactive item with another selector, like
.js-timeline-item[refined-github-inactive-item]
. A simple CSS rule would add adisplay: none
and we're done.Edit: One should only hide the
.discussion-item
, not the whole.js-timeline-item
.The text was updated successfully, but these errors were encountered: