Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By default, don't permanently delete when recycle bin doesn't exist #8

Open
sindresorhus opened this issue Dec 18, 2020 · 1 comment

Comments

@sindresorhus
Copy link
Owner

I think that's a better default. We can add a flag to get back the old behavior.

It seems like we can use the FOF_WANTNUKEWARNING flag for this:

Send a warning if a file or folder is being destroyed during a delete operation rather than recycled. This flag partially overrides FOF_NOCONFIRMATION. - https://docs.microsoft.com/en-us/windows/win32/api/shobjidl_core/nf-shobjidl_core-ifileoperation-setoperationflags

It's not immediately clear what they mean by warning and how we could check for that though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants