From 3478c0aa0eb7d0f09efcd82853ff9322919966bd Mon Sep 17 00:00:00 2001 From: Sindre Sorhus Date: Sat, 3 Feb 2024 17:11:13 +0700 Subject: [PATCH] Meta tweaks --- .github/funding.yml | 4 ---- .github/workflows/main.yml | 4 ++-- base.d.ts | 2 +- package.json | 1 + readme.md | 2 +- 5 files changed, 5 insertions(+), 8 deletions(-) delete mode 100644 .github/funding.yml diff --git a/.github/funding.yml b/.github/funding.yml deleted file mode 100644 index 07c8db1c..00000000 --- a/.github/funding.yml +++ /dev/null @@ -1,4 +0,0 @@ -github: sindresorhus -open_collective: sindresorhus -tidelift: npm/query-string -custom: https://sindresorhus.com/donate diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index d50ada65..31f93e98 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -14,8 +14,8 @@ jobs: - 16 - 14 steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} - run: npm install diff --git a/base.d.ts b/base.d.ts index f6bbd9a5..4a2a3b00 100644 --- a/base.d.ts +++ b/base.d.ts @@ -220,7 +220,7 @@ export function parseUrl(url: string, options?: ParseOptions): ParsedUrl; export type StringifyOptions = { /** - Strictly encode URI components with [`strict-uri-encode`](https://github.com/kevva/strict-uri-encode). It uses [`encodeURIComponent`](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent) if set to `false`. You probably [don't care](https://github.com/sindresorhus/query-string/issues/42) about this option. + Strictly encode URI components. It uses [`encodeURIComponent`](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent) if set to `false`. You probably [don't care](https://github.com/sindresorhus/query-string/issues/42) about this option. @default true */ diff --git a/package.json b/package.json index 41dc0e4c..023fe2a5 100644 --- a/package.json +++ b/package.json @@ -15,6 +15,7 @@ "types": "./index.d.ts", "default": "./index.js" }, + "sideEffects": false, "engines": { "node": ">=14.16" }, diff --git a/readme.md b/readme.md index 85d9a715..537a7c4c 100644 --- a/readme.md +++ b/readme.md @@ -236,7 +236,7 @@ Type: `object` Type: `boolean`\ Default: `true` -Strictly encode URI components with [strict-uri-encode](https://github.com/kevva/strict-uri-encode). It uses [encodeURIComponent](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent) if set to false. You probably [don't care](https://github.com/sindresorhus/query-string/issues/42) about this option. +Strictly encode URI components. It uses [encodeURIComponent](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent) if set to false. You probably [don't care](https://github.com/sindresorhus/query-string/issues/42) about this option. ##### encode