-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add binary
option
#60
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmoinvaz
force-pushed
the
master
branch
2 times, most recently
from
August 11, 2020 21:38
63d5b01
to
75676a3
Compare
Looks like there is a bug in the CI due to Node 6 support and |
nmoinvaz
force-pushed
the
master
branch
7 times, most recently
from
August 12, 2020 00:37
aa594a0
to
8f3bfe3
Compare
sindresorhus
requested changes
Aug 12, 2020
Remove unnecessary parentheses.
Make sure running |
sindresorhus
changed the title
Added binary option to enable 1024 based counting.
Add Aug 16, 2020
binary
option
I had to modify npm test command to get it to work on Windows using |
Turbo87
reviewed
Aug 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is not mine but I am submitting so this feature gets into mainline.