diff --git a/.github/funding.yml b/.github/funding.yml deleted file mode 100644 index 218b9e0..0000000 --- a/.github/funding.yml +++ /dev/null @@ -1,4 +0,0 @@ -github: sindresorhus -open_collective: sindresorhus -tidelift: npm/open -custom: https://sindresorhus.com/donate diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index d5cb8dc..346585c 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -12,11 +12,9 @@ jobs: node-version: - 20 - 18 - - 16 - - 14 steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} - run: npm install diff --git a/index.js b/index.js index c79501e..59a3de6 100644 --- a/index.js +++ b/index.js @@ -3,8 +3,7 @@ import {Buffer} from 'node:buffer'; import path from 'node:path'; import {fileURLToPath} from 'node:url'; import childProcess from 'node:child_process'; -import fs from 'node:fs/promises'; -import {constants as fsConstants} from 'node:fs'; // TODO: Move this to the above import when targeting Node.js 18. +import fs, {constants as fsConstants} from 'node:fs/promises'; import isWsl from 'is-wsl'; import defineLazyProperty from 'define-lazy-prop'; import defaultBrowser from 'default-browser'; @@ -202,7 +201,7 @@ const baseOpen = async options => { } if (appArguments.length > 0) { - appArguments = appArguments.map(arg => `"\`"${arg}\`""`); + appArguments = appArguments.map(argument => `"\`"${argument}\`""`); encodedArguments.push('-ArgumentList', appArguments.join(',')); } diff --git a/package.json b/package.json index 24c739c..17e18bf 100644 --- a/package.json +++ b/package.json @@ -15,8 +15,9 @@ "types": "./index.d.ts", "default": "./index.js" }, + "sideEffects": false, "engines": { - "node": ">=14.16" + "node": ">=18" }, "scripts": { "test": "xo && tsd" @@ -53,15 +54,15 @@ "file" ], "dependencies": { - "default-browser": "^4.0.0", + "default-browser": "^5.2.0", "define-lazy-prop": "^3.0.0", "is-inside-container": "^1.0.0", - "is-wsl": "^2.2.0" + "is-wsl": "^3.1.0" }, "devDependencies": { - "@types/node": "^18.15.10", - "ava": "^5.2.0", - "tsd": "^0.28.0", - "xo": "^0.54.2" + "@types/node": "^20.10.5", + "ava": "^6.0.1", + "tsd": "^0.30.0", + "xo": "^0.56.0" } } diff --git a/test.js b/test.js index e7d376c..bedfa8d 100644 --- a/test.js +++ b/test.js @@ -28,8 +28,8 @@ test('open URL in specified app', async t => { test('open URL in specified app with arguments', async t => { await t.notThrowsAsync(async () => { - const proc = await open('https://sindresorhus.com', {app: {name: apps.chrome, arguments: ['--incognito']}}); - t.deepEqual(proc.spawnargs, ['open', '-a', apps.chrome, 'https://sindresorhus.com', '--args', '--incognito']); + const process_ = await open('https://sindresorhus.com', {app: {name: apps.chrome, arguments: ['--incognito']}}); + t.deepEqual(process_.spawnargs, ['open', '-a', apps.chrome, 'https://sindresorhus.com', '--args', '--incognito']); }); }); diff --git a/xdg-open b/xdg-open index b392fbf..955734d 100755 --- a/xdg-open +++ b/xdg-open @@ -7,519 +7,33 @@ # Refer to the usage() function below for usage. # # Copyright 2009-2010, Fathi Boudra -# Copyright 2009-2010, Rex Dieter +# Copyright 2009-2016, Rex Dieter # Copyright 2006, Kevin Krammer # Copyright 2006, Jeremy White # # LICENSE: # -# Permission is hereby granted, free of charge, to any person obtaining a -# copy of this software and associated documentation files (the "Software"), -# to deal in the Software without restriction, including without limitation -# the rights to use, copy, modify, merge, publish, distribute, sublicense, -# and/or sell copies of the Software, and to permit persons to whom the -# Software is furnished to do so, subject to the following conditions: -# -# The above copyright notice and this permission notice shall be included -# in all copies or substantial portions of the Software. -# -# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS -# OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, -# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL -# THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR -# OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, -# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR -# OTHER DEALINGS IN THE SOFTWARE. -# #--------------------------------------------- manualpage() { cat << _MANUALPAGE -Name - - xdg-open -- opens a file or URL in the user's preferred - application - -Synopsis - - xdg-open { file | URL } - - xdg-open { --help | --manual | --version } - -Description - - xdg-open opens a file or URL in the user's preferred - application. If a URL is provided the URL will be opened in the - user's preferred web browser. If a file is provided the file - will be opened in the preferred application for files of that - type. xdg-open supports file, ftp, http and https URLs. - - xdg-open is for use inside a desktop session only. It is not - recommended to use xdg-open as root. - -Options - - --help - Show command synopsis. - - --manual - Show this manual page. - - --version - Show the xdg-utils version information. - -Exit Codes - - An exit code of 0 indicates success while a non-zero exit code - indicates failure. The following failure codes can be returned: - - 1 - Error in command line syntax. - - 2 - One of the files passed on the command line did not - exist. - - 3 - A required tool could not be found. - - 4 - The action failed. - -See Also - - xdg-mime(1), xdg-settings(1), MIME applications associations - specification - -Examples - -xdg-open 'http://www.freedesktop.org/' - - Opens the freedesktop.org website in the user's default - browser. - -xdg-open /tmp/foobar.png - - Opens the PNG image file /tmp/foobar.png in the user's default - image viewing application. _MANUALPAGE } usage() { cat << _USAGE - xdg-open -- opens a file or URL in the user's preferred - application - -Synopsis - - xdg-open { file | URL } - - xdg-open { --help | --manual | --version } - _USAGE } #@xdg-utils-common@ -#---------------------------------------------------------------------------- -# Common utility functions included in all XDG wrapper scripts -#---------------------------------------------------------------------------- - -DEBUG() -{ - [ -z "${XDG_UTILS_DEBUG_LEVEL}" ] && return 0; - [ ${XDG_UTILS_DEBUG_LEVEL} -lt $1 ] && return 0; - shift - echo "$@" >&2 -} - -# This handles backslashes but not quote marks. -first_word() -{ - read first rest - echo "$first" -} - -#------------------------------------------------------------- -# map a binary to a .desktop file -binary_to_desktop_file() -{ - search="${XDG_DATA_HOME:-$HOME/.local/share}:${XDG_DATA_DIRS:-/usr/local/share:/usr/share}" - binary="`which "$1"`" - binary="`readlink -f "$binary"`" - base="`basename "$binary"`" - IFS=: - for dir in $search; do - unset IFS - [ "$dir" ] || continue - [ -d "$dir/applications" ] || [ -d "$dir/applnk" ] || continue - for file in "$dir"/applications/*.desktop "$dir"/applications/*/*.desktop "$dir"/applnk/*.desktop "$dir"/applnk/*/*.desktop; do - [ -r "$file" ] || continue - # Check to make sure it's worth the processing. - grep -q "^Exec.*$base" "$file" || continue - # Make sure it's a visible desktop file (e.g. not "preferred-web-browser.desktop"). - grep -Eq "^(NoDisplay|Hidden)=true" "$file" && continue - command="`grep -E "^Exec(\[[^]=]*])?=" "$file" | cut -d= -f 2- | first_word`" - command="`which "$command"`" - if [ x"`readlink -f "$command"`" = x"$binary" ]; then - # Fix any double slashes that got added path composition - echo "$file" | sed -e 's,//*,/,g' - return - fi - done - done -} - -#------------------------------------------------------------- -# map a .desktop file to a binary -desktop_file_to_binary() -{ - search="${XDG_DATA_HOME:-$HOME/.local/share}:${XDG_DATA_DIRS:-/usr/local/share:/usr/share}" - desktop="`basename "$1"`" - IFS=: - for dir in $search; do - unset IFS - [ "$dir" ] && [ -d "$dir/applications" ] || [ -d "$dir/applnk" ] || continue - # Check if desktop file contains - - if [ "${desktop#*-}" != "$desktop" ]; then - vendor=${desktop%-*} - app=${desktop#*-} - if [ -r $dir/applications/$vendor/$app ]; then - file_path=$dir/applications/$vendor/$app - elif [ -r $dir/applnk/$vendor/$app ]; then - file_path=$dir/applnk/$vendor/$app - fi - fi - if test -z "$file_path" ; then - for indir in "$dir"/applications/ "$dir"/applications/*/ "$dir"/applnk/ "$dir"/applnk/*/; do - file="$indir/$desktop" - if [ -r "$file" ]; then - file_path=$file - break - fi - done - fi - if [ -r "$file_path" ]; then - # Remove any arguments (%F, %f, %U, %u, etc.). - command="`grep -E "^Exec(\[[^]=]*])?=" "$file_path" | cut -d= -f 2- | first_word`" - command="`which "$command"`" - readlink -f "$command" - return - fi - done -} - -#------------------------------------------------------------- -# Exit script on successfully completing the desired operation - -exit_success() -{ - if [ $# -gt 0 ]; then - echo "$@" - echo - fi - - exit 0 -} - - -#----------------------------------------- -# Exit script on malformed arguments, not enough arguments -# or missing required option. -# prints usage information - -exit_failure_syntax() -{ - if [ $# -gt 0 ]; then - echo "xdg-open: $@" >&2 - echo "Try 'xdg-open --help' for more information." >&2 - else - usage - echo "Use 'man xdg-open' or 'xdg-open --manual' for additional info." - fi - - exit 1 -} - -#------------------------------------------------------------- -# Exit script on missing file specified on command line - -exit_failure_file_missing() -{ - if [ $# -gt 0 ]; then - echo "xdg-open: $@" >&2 - fi - - exit 2 -} - -#------------------------------------------------------------- -# Exit script on failure to locate necessary tool applications - -exit_failure_operation_impossible() -{ - if [ $# -gt 0 ]; then - echo "xdg-open: $@" >&2 - fi - - exit 3 -} - -#------------------------------------------------------------- -# Exit script on failure returned by a tool application - -exit_failure_operation_failed() -{ - if [ $# -gt 0 ]; then - echo "xdg-open: $@" >&2 - fi - - exit 4 -} - -#------------------------------------------------------------ -# Exit script on insufficient permission to read a specified file - -exit_failure_file_permission_read() -{ - if [ $# -gt 0 ]; then - echo "xdg-open: $@" >&2 - fi - - exit 5 -} - -#------------------------------------------------------------ -# Exit script on insufficient permission to write a specified file - -exit_failure_file_permission_write() -{ - if [ $# -gt 0 ]; then - echo "xdg-open: $@" >&2 - fi - - exit 6 -} - -check_input_file() -{ - if [ ! -e "$1" ]; then - exit_failure_file_missing "file '$1' does not exist" - fi - if [ ! -r "$1" ]; then - exit_failure_file_permission_read "no permission to read file '$1'" - fi -} - -check_vendor_prefix() -{ - file_label="$2" - [ -n "$file_label" ] || file_label="filename" - file=`basename "$1"` - case "$file" in - [[:alpha:]]*-*) - return - ;; - esac - - echo "xdg-open: $file_label '$file' does not have a proper vendor prefix" >&2 - echo 'A vendor prefix consists of alpha characters ([a-zA-Z]) and is terminated' >&2 - echo 'with a dash ("-"). An example '"$file_label"' is '"'example-$file'" >&2 - echo "Use --novendor to override or 'xdg-open --manual' for additional info." >&2 - exit 1 -} - -check_output_file() -{ - # if the file exists, check if it is writeable - # if it does not exists, check if we are allowed to write on the directory - if [ -e "$1" ]; then - if [ ! -w "$1" ]; then - exit_failure_file_permission_write "no permission to write to file '$1'" - fi - else - DIR=`dirname "$1"` - if [ ! -w "$DIR" ] || [ ! -x "$DIR" ]; then - exit_failure_file_permission_write "no permission to create file '$1'" - fi - fi -} - -#---------------------------------------- -# Checks for shared commands, e.g. --help - -check_common_commands() -{ - while [ $# -gt 0 ] ; do - parm="$1" - shift - - case "$parm" in - --help) - usage - echo "Use 'man xdg-open' or 'xdg-open --manual' for additional info." - exit_success - ;; - - --manual) - manualpage - exit_success - ;; - - --version) - echo "xdg-open 1.1.3" - exit_success - ;; - esac - done -} - -check_common_commands "$@" - -[ -z "${XDG_UTILS_DEBUG_LEVEL}" ] && unset XDG_UTILS_DEBUG_LEVEL; -if [ ${XDG_UTILS_DEBUG_LEVEL-0} -lt 1 ]; then - # Be silent - xdg_redirect_output=" > /dev/null 2> /dev/null" -else - # All output to stderr - xdg_redirect_output=" >&2" -fi - -#-------------------------------------- -# Checks for known desktop environments -# set variable DE to the desktop environments name, lowercase - -detectDE() -{ - # see https://bugs.freedesktop.org/show_bug.cgi?id=34164 - unset GREP_OPTIONS - - if [ -n "${XDG_CURRENT_DESKTOP}" ]; then - case "${XDG_CURRENT_DESKTOP}" in - # only recently added to menu-spec, pre-spec X- still in use - Cinnamon|X-Cinnamon) - DE=cinnamon; - ;; - ENLIGHTENMENT) - DE=enlightenment; - ;; - # GNOME, GNOME-Classic:GNOME, or GNOME-Flashback:GNOME - GNOME*) - DE=gnome; - ;; - KDE) - DE=kde; - ;; - # Deepin Desktop Environments - DEEPIN|Deepin|deepin) - DE=dde; - ;; - LXDE) - DE=lxde; - ;; - LXQt) - DE=lxqt; - ;; - MATE) - DE=mate; - ;; - XFCE) - DE=xfce - ;; - X-Generic) - DE=generic - ;; - esac - fi - - if [ x"$DE" = x"" ]; then - # classic fallbacks - if [ x"$KDE_FULL_SESSION" != x"" ]; then DE=kde; - elif [ x"$GNOME_DESKTOP_SESSION_ID" != x"" ]; then DE=gnome; - elif [ x"$MATE_DESKTOP_SESSION_ID" != x"" ]; then DE=mate; - elif `dbus-send --print-reply --dest=org.freedesktop.DBus /org/freedesktop/DBus org.freedesktop.DBus.GetNameOwner string:org.gnome.SessionManager > /dev/null 2>&1` ; then DE=gnome; - elif xprop -root _DT_SAVE_MODE 2> /dev/null | grep ' = \"xfce4\"$' >/dev/null 2>&1; then DE=xfce; - elif xprop -root 2> /dev/null | grep -i '^xfce_desktop_window' >/dev/null 2>&1; then DE=xfce - elif echo $DESKTOP | grep -q '^Enlightenment'; then DE=enlightenment; - elif [ x"$LXQT_SESSION_CONFIG" != x"" ]; then DE=lxqt; - fi - fi - - if [ x"$DE" = x"" ]; then - # fallback to checking $DESKTOP_SESSION - case "$DESKTOP_SESSION" in - gnome) - DE=gnome; - ;; - LXDE|Lubuntu) - DE=lxde; - ;; - MATE) - DE=mate; - ;; - xfce|xfce4|'Xfce Session') - DE=xfce; - ;; - esac - fi - - if [ x"$DE" = x"" ]; then - # fallback to uname output for other platforms - case "$(uname 2>/dev/null)" in - CYGWIN*) - DE=cygwin; - ;; - Darwin) - DE=darwin; - ;; - esac - fi - - if [ x"$DE" = x"gnome" ]; then - # gnome-default-applications-properties is only available in GNOME 2.x - # but not in GNOME 3.x - which gnome-default-applications-properties > /dev/null 2>&1 || DE="gnome3" - fi - - if [ -f "$XDG_RUNTIME_DIR/flatpak-info" ]; then - DE="flatpak" - fi -} - -#---------------------------------------------------------------------------- -# kfmclient exec/openURL can give bogus exit value in KDE <= 3.5.4 -# It also always returns 1 in KDE 3.4 and earlier -# Simply return 0 in such case - -kfmclient_fix_exit_code() -{ - version=`LC_ALL=C.UTF-8 kde-config --version 2>/dev/null | grep '^KDE'` - major=`echo $version | sed 's/KDE.*: \([0-9]\).*/\1/'` - minor=`echo $version | sed 's/KDE.*: [0-9]*\.\([0-9]\).*/\1/'` - release=`echo $version | sed 's/KDE.*: [0-9]*\.[0-9]*\.\([0-9]\).*/\1/'` - test "$major" -gt 3 && return $1 - test "$minor" -gt 5 && return $1 - test "$release" -gt 4 && return $1 - return 0 -} - -#---------------------------------------------------------------------------- -# Returns true if there is a graphical display attached. - -has_display() -{ - if [ -n "$DISPLAY" ] || [ -n "$WAYLAND_DISPLAY" ]; then - return 0 - else - return 1 - fi -} - # This handles backslashes but not quote marks. last_word() { + # Backslash handling is intended, not using `first` too + # shellcheck disable=SC2162,SC2034 read first rest echo "$rest" } @@ -535,7 +49,8 @@ get_key() IFS_="${IFS}" IFS="" - while read line + # No backslash handling here, first_word and last_word do that + while read -r line do case "$line" in "[Desktop Entry]") @@ -556,26 +71,47 @@ get_key() IFS="${IFS_}" } +has_url_scheme() +{ + echo "$1" | LC_ALL=C grep -Eq '^[[:alpha:]][[:alpha:][:digit:]+\.\-]*:' +} + # Returns true if argument is a file:// URL or path is_file_url_or_path() { - if echo "$1" | grep -q '^file://' \ - || ! echo "$1" | egrep -q '^[[:alpha:]+\.\-]+:'; then + if echo "$1" | grep -q '^file://' || ! has_url_scheme "$1" ; then return 0 else return 1 fi } +get_hostname() { + if [ -z "$HOSTNAME" ]; then + if command -v hostname > /dev/null; then + HOSTNAME=$(hostname) + else + HOSTNAME=$(uname -n) + fi + fi +} + # If argument is a file URL, convert it to a (percent-decoded) path. # If not, leave it as it is. file_url_to_path() { local file="$1" - if echo "$file" | grep -q '^file:///'; then + get_hostname + if echo "$file" | grep -q '^file://'; then + file=${file#file://localhost} + file=${file#file://"$HOSTNAME"} file=${file#file://} + if ! echo "$file" | grep -q '^/'; then + echo "$file" + return + fi file=${file%%#*} - file=$(echo "$file" | sed -r 's/\?.*$//') + file=${file%%\?*} local printf=printf if [ -x /usr/bin/printf ]; then printf=/usr/bin/printf @@ -615,7 +151,10 @@ open_kde() kde-open "$1" ;; 5) - kde-open${KDE_SESSION_VERSION} "$1" + "kde-open${KDE_SESSION_VERSION}" "$1" + ;; + 6) + kde-open "$1" ;; esac else @@ -630,7 +169,7 @@ open_kde() fi } -open_dde() +open_deepin() { if dde-open -version >/dev/null 2>&1; then dde-open "$1" @@ -736,11 +275,28 @@ open_enlightenment() open_flatpak() { - gdbus call --session \ - --dest org.freedesktop.portal.Desktop \ - --object-path /org/freedesktop/portal/desktop \ - --method org.freedesktop.portal.OpenURI.OpenURI \ - "" "$1" {} + if is_file_url_or_path "$1"; then + local file + file="$(file_url_to_path "$1")" + + check_input_file "$file" + + gdbus call --session \ + --dest org.freedesktop.portal.Desktop \ + --object-path /org/freedesktop/portal/desktop \ + --method org.freedesktop.portal.OpenURI.OpenFile \ + --timeout 5 \ + "" "3" {} 3< "$file" + else + # $1 contains an URI + + gdbus call --session \ + --dest org.freedesktop.portal.Desktop \ + --object-path /org/freedesktop/portal/desktop \ + --method org.freedesktop.portal.OpenURI.OpenURI \ + --timeout 5 \ + "" "$1" {} + fi if [ $? -eq 0 ]; then exit_success @@ -752,79 +308,91 @@ open_flatpak() #----------------------------------------- # Recursively search .desktop file +#(application, directory, target file, target_url) search_desktop_file() { local default="$1" local dir="$2" local target="$3" + local target_uri="$4" local file="" # look for both vendor-app.desktop, vendor/app.desktop if [ -r "$dir/$default" ]; then file="$dir/$default" - elif [ -r "$dir/`echo $default | sed -e 's|-|/|'`" ]; then - file="$dir/`echo $default | sed -e 's|-|/|'`" + elif [ -r "$dir/$(echo "$default" | sed -e 's|-|/|')" ]; then + file="$dir/$(echo "$default" | sed -e 's|-|/|')" fi if [ -r "$file" ] ; then command="$(get_key "${file}" "Exec" | first_word)" - command_exec=`which $command 2>/dev/null` - icon="$(get_key "${file}" "Icon")" - # FIXME: Actually LC_MESSAGES should be used as described in - # http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s04.html - localised_name="$(get_key "${file}" "Name")" - set -- $(get_key "${file}" "Exec" | last_word) - # We need to replace any occurrence of "%f", "%F" and - # the like by the target file. We examine each - # argument and append the modified argument to the - # end then shift. - local args=$# - local replaced=0 - while [ $args -gt 0 ]; do - case $1 in - %[c]) - replaced=1 - arg="${localised_name}" - shift - set -- "$@" "$arg" - ;; - %[fFuU]) - replaced=1 - arg="$target" - shift - set -- "$@" "$arg" - ;; - %[i]) - replaced=1 - shift - set -- "$@" "--icon" "$icon" - ;; - *) - arg="$1" - shift - set -- "$@" "$arg" - ;; - esac - args=$(( $args - 1 )) - done - [ $replaced -eq 1 ] || set -- "$@" "$target" - "$command_exec" "$@" - - if [ $? -eq 0 ]; then + if command -v "$command" >/dev/null; then + icon="$(get_key "${file}" "Icon")" + # FIXME: Actually LC_MESSAGES should be used as described in + # http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s04.html + localised_name="$(get_key "${file}" "Name")" + #shellcheck disable=SC2046 # Splitting is intentional here + set -- $(get_key "${file}" "Exec" | last_word) + # We need to replace any occurrence of "%f", "%F" and + # the like by the target file. We examine each + # argument and append the modified argument to the + # end then shift. + local args=$# + local replaced=0 + while [ $args -gt 0 ]; do + case $1 in + %[c]) + replaced=1 + arg="${localised_name}" + shift + set -- "$@" "$arg" + ;; + %[fF]) + # if there is only a target_url return, + # this application can't handle it. + [ -n "$target" ] || return + replaced=1 + arg="$target" + shift + set -- "$@" "$arg" + ;; + %[uU]) + replaced=1 + # When an URI is requested use it, + # otherwise fall back to the filepath. + arg="${target_uri:-$target}" + shift + set -- "$@" "$arg" + ;; + %[i]) + replaced=1 + shift + set -- "$@" "--icon" "$icon" + ;; + *) + arg="$1" + shift + set -- "$@" "$arg" + ;; + esac + args=$(( args - 1 )) + done + [ $replaced -eq 1 ] || set -- "$@" "${target:-$target_uri}" + env "$command" "$@" exit_success fi fi - for d in $dir/*/; do - [ -d "$d" ] && search_desktop_file "$default" "$d" "$target" + for d in "$dir/"*/; do + [ -d "$d" ] && search_desktop_file "$default" "$d" "$target" "$target_uri" done } - +# (file (or empty), mimetype, optional url) open_generic_xdg_mime() { filetype="$2" - default=`xdg-mime query default "$filetype"` + default="$(xdg-mime query default "$filetype")" if [ -n "$default" ] ; then xdg_user_dir="$XDG_DATA_HOME" [ -n "$xdg_user_dir" ] || xdg_user_dir="$HOME/.local/share" @@ -832,25 +400,23 @@ open_generic_xdg_mime() xdg_system_dirs="$XDG_DATA_DIRS" [ -n "$xdg_system_dirs" ] || xdg_system_dirs=/usr/local/share/:/usr/share/ -DEBUG 3 "$xdg_user_dir:$xdg_system_dirs" - for x in `echo "$xdg_user_dir:$xdg_system_dirs" | sed 's/:/ /g'`; do - search_desktop_file "$default" "$x/applications/" "$1" + search_dirs="$xdg_user_dir:$xdg_system_dirs" + DEBUG 3 "$search_dirs" + old_ifs="$IFS" + IFS=: + for x in $search_dirs ; do + IFS="$old_ifs" + search_desktop_file "$default" "$x/applications/" "$1" "$3" done fi } -open_generic_xdg_file_mime() -{ - filetype=`xdg-mime query filetype "$1" | sed "s/;.*//"` - open_generic_xdg_mime "$1" "$filetype" -} - open_generic_xdg_x_scheme_handler() { - scheme="`echo $1 | sed -n 's/\(^[[:alnum:]+\.-]*\):.*$/\1/p'`" - if [ -n $scheme ]; then + scheme="$(echo "$1" | LC_ALL=C sed -n 's/\(^[[:alpha:]][[:alnum:]+\.-]*\):.*$/\1/p')" + if [ -n "$scheme" ]; then filetype="x-scheme-handler/$scheme" - open_generic_xdg_mime "$1" "$filetype" + open_generic_xdg_mime "" "$filetype" "$1" fi } @@ -862,7 +428,7 @@ has_single_argument() open_envvar() { local oldifs="$IFS" - local browser browser_with_arg + local browser IFS=":" for browser in $BROWSER; do @@ -876,6 +442,8 @@ open_envvar() # Avoid argument injection. # See https://bugs.freedesktop.org/show_bug.cgi?id=103807 # URIs don't have IFS characters spaces anyway. + # shellcheck disable=SC2086,SC2091,SC2059 + # All the scary things here are intentional has_single_argument $1 && $(printf "$browser" "$1") else $browser "$1" @@ -887,19 +455,40 @@ open_envvar() done } +open_wsl() +{ + local win_path + if has_url_scheme "$1"; then + win_path="$1" + else + win_path="$(wslpath -aw "$1")" + [ $? -eq 0 ] || exit_failure_operation_failed + fi + explorer.exe "${win_path}" + + if [ $? -eq 0 ]; then + exit_success + else + exit_failure_operation_failed + fi +} + open_generic() { if is_file_url_or_path "$1"; then - local file="$(file_url_to_path "$1")" + local file + file="$(file_url_to_path "$1")" check_input_file "$file" if has_display; then - filetype=`xdg-mime query filetype "$file" | sed "s/;.*//"` - open_generic_xdg_mime "$file" "$filetype" + filetype="$(xdg-mime query filetype "$file" | sed "s/;.*//")" + # passing a path a url is okay too, + # see desktop file specification for '%u' + open_generic_xdg_mime "$file" "$filetype" "$1" fi - if which run-mailcap 2>/dev/null 1>&2; then + if command -v run-mailcap >/dev/null; then run-mailcap --action=view "$file" if [ $? -eq 0 ]; then exit_success @@ -926,7 +515,7 @@ open_generic() if [ x"$BROWSER" = x"" ]; then BROWSER=www-browser:links2:elinks:links:lynx:w3m if has_display; then - BROWSER=x-www-browser:firefox:iceweasel:seamonkey:mozilla:epiphany:konqueror:chromium:chromium-browser:google-chrome:microsoft-edge:$BROWSER + BROWSER=x-www-browser:firefox:iceweasel:seamonkey:mozilla:epiphany:konqueror:chromium:chromium-browser:google-chrome:$BROWSER fi fi @@ -940,7 +529,8 @@ open_lxde() # pcmanfm only knows how to handle file:// urls and filepaths, it seems. if pcmanfm --help >/dev/null 2>&1 && is_file_url_or_path "$1"; then - local file="$(file_url_to_path "$1")" + local file + file="$(file_url_to_path "$1")" # handle relative paths if ! echo "$file" | grep -q ^/; then @@ -961,7 +551,17 @@ open_lxde() open_lxqt() { - open_generic "$1" + if qtxdg-mat open --help 2>/dev/null 1>&2; then + qtxdg-mat open "$1" + else + exit_failure_operation_impossible "no method available for opening '$1'" + fi + + if [ $? -eq 0 ]; then + exit_success + else + exit_failure_operation_failed + fi } [ x"$1" != x"" ] || exit_failure_syntax @@ -997,10 +597,10 @@ fi DEBUG 2 "Selected DE $DE" -# sanitize BROWSER (avoid caling ourselves in particular) +# sanitize BROWSER (avoid calling ourselves in particular) case "${BROWSER}" in *:"xdg-open"|"xdg-open":*) - BROWSER=$(echo $BROWSER | sed -e 's|:xdg-open||g' -e 's|xdg-open:||g') + BROWSER="$(echo "$BROWSER" | sed -e 's|:xdg-open||g' -e 's|xdg-open:||g')" ;; "xdg-open") BROWSER= @@ -1012,8 +612,8 @@ case "$DE" in open_kde "$url" ;; - dde) - open_dde "$url" + deepin) + open_deepin "$url" ;; gnome3|cinnamon) @@ -1056,6 +656,10 @@ case "$DE" in open_flatpak "$url" ;; + wsl) + open_wsl "$url" + ;; + generic) open_generic "$url" ;;