Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The releaseDraft step appears to be skipped in my setup #542

Closed
dhowe opened this issue Jun 7, 2020 · 7 comments
Closed

The releaseDraft step appears to be skipped in my setup #542

dhowe opened this issue Jun 7, 2020 · 7 comments

Comments

@dhowe
Copy link

dhowe commented Jun 7, 2020

The releaseDraft step appears to be skipped in my setup

Description

My config is simple. I run the following via yarn:

$ np --tag beta prerelease

and see the following output (this time in preview mode):

Publish a new version of XXX (current: 2.0.0-beta.12)

Commits:
- Update README.md  ad57d44

Commit Range:
v2.0.0-beta.12...master

Registry:
https://registry.yarnpkg.com


  ✔ Prerequisite check
  ✔ Git
  ↓ Cleanup [skipped]
  ✔ Installing dependencies using Yarn
  ✔ Running tests using Yarn
  ↓ Bumping version using Yarn [skipped]
    → [Preview] Command not executed: yarn version --new-version prerelease.
  ↓ Publishing package using Yarn [skipped]
    → [Preview] Command not executed: yarn publish --tag beta.
  ↓ Pushing tags [skipped]
    → [Preview] Command not executed: git push --follow-tags.
✨  Done in 15.93s.

Expected behavior

That it does all those steps but also creates a release on Github

Environment

np - 6.2.3
Node.js - v13.6.0
yarn - 1.22.4
Git - 2.24.3
OS - OS X 10.15.4

@sindresorhus
Copy link
Owner

// @ChrisEbert

@ChrisEbert
Copy link
Contributor

That seems a bit weird to me, because the 'releaseDraft' setting should always be visible in the task list, whether it is enabled or not. Only changes from #513 could hide the task from the list.
There is also no connection to #540 because @dhowe is using [email protected]

Unfortunately I could not reproduce the issue in my tests. 😞

@dhowe
Copy link
Author

dhowe commented Jun 9, 2020

If one wanted to exclude this step, how would they do it?

@ChrisEbert
Copy link
Contributor

$ np --no-release-draft skips this step. Nevertheless it would be listed in the cli output like this:

  ✔ Git
  ✔ Running tests using Yarn
  ✔ Bumping version using Yarn
  ✔ Pushing tags
  ↓ Creating release draft on GitHub [skipped]

@sonicdoe
Copy link
Contributor

sonicdoe commented Jun 9, 2020

The release draft task will be hidden if the repository is not hosted on GitHub. What’s in your package.json’s repository field? This field is used to determine where the repository is hosted.

@dhowe
Copy link
Author

dhowe commented Jun 10, 2020

ah, that's it of course (its on github but I had somehow neglected to add the repo field in the package file). thanks for helping me get to the bottom of this!

@dhowe dhowe closed this as completed Jun 10, 2020
@sonicdoe
Copy link
Contributor

Good to hear 👍 I think it’s worth adding this to the FAQ or letting np automatically infer the repository from the Git remote.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants