Set default release branch to main or master

sindresorhus · Jul 21, 2020 · 81007df · 81007df
1 parent b4bef72
commit 81007df
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 5 deletions.
diff --git a/source/git-util.js b/source/git-util.js
@@ -38,9 +38,11 @@ exports.currentBranch = async () => {
 	return stdout;
 };
 
-exports.verifyCurrentBranchIsReleaseBranch = async (releaseBranch = 'master') => {
-	if (await exports.currentBranch() !== releaseBranch) {
-		throw new Error(`Not on \`${releaseBranch}\` branch. Use --any-branch to publish anyway, or set a different release branch using --branch.`);
+exports.verifyCurrentBranchIsReleaseBranch = async releaseBranch => {
+	const allowedBranches = releaseBranch ? [releaseBranch] : ['main', 'master'];
+	const currentBranch = await exports.currentBranch();
+	if (!allowedBranches.includes(currentBranch)) {
+		throw new Error(`Not on ${allowedBranches.map(br => `\`${br}\``).join('/')} branch. Use --any-branch to publish anyway, or set a different release branch using --branch.`);
 	}
 };
 

diff --git a/test/git-tasks.js b/test/git-tasks.js
@@ -24,6 +24,19 @@ test.beforeEach(() => {
 	execaStub.resetStub();
 });
 
+test.serial('should fail when release branch is not specified, current branch is not main/master and publishing from any branch not permitted', async t => {
+	execaStub.createStub([
+		{
+			command: 'git symbolic-ref --short HEAD',
+			exitCode: 0,
+			stdout: 'feature'
+		}
+	]);
+	await t.throwsAsync(run(testedModule({})),
+		{message: 'Not on `main`/`master` branch. Use --any-branch to publish anyway, or set a different release branch using --branch.'});
+	t.true(SilentRenderer.tasks.some(task => task.title === 'Check current branch' && task.hasFailed()));
+});
+
 test.serial('should fail when current branch is not the specified release branch and publishing from any branch not permitted', async t => {
 	execaStub.createStub([
 		{
@@ -32,8 +45,8 @@ test.serial('should fail when current branch is not the specified release branch
 			stdout: 'feature'
 		}
 	]);
-	await t.throwsAsync(run(testedModule({branch: 'main'})),
-		{message: 'Not on `main` branch. Use --any-branch to publish anyway, or set a different release branch using --branch.'});
+	await t.throwsAsync(run(testedModule({branch: 'release'})),
+		{message: 'Not on `release` branch. Use --any-branch to publish anyway, or set a different release branch using --branch.'});
 	t.true(SilentRenderer.tasks.some(task => task.title === 'Check current branch' && task.hasFailed()));
 });