Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show notification shelf #237

Closed
acomagu opened this issue Dec 29, 2020 · 2 comments
Closed

Show notification shelf #237

acomagu opened this issue Dec 29, 2020 · 2 comments

Comments

@acomagu
Copy link

acomagu commented Dec 29, 2020

The top bar we can see on issue/pull page when I jump from github.com/notifications(seems to be called "notification shelf") is not shown if we jump by clicking desktop notification from this extension.

Screenshot_20201230_073821

The buttons are useful to operate the notification quickly.

@acomagu
Copy link
Author

acomagu commented Dec 29, 2020

I noticed it's shown if I attach notification_referrer_id query param, like https://github.com/sindresorhus/notifier-for-github/issues/1?notification_referrer_id=FOO. But I couldn't find out the ID in GitHub API. I guess scraping may be the only way to do currently 😕

@notlmn
Copy link
Collaborator

notlmn commented Dec 30, 2020

Yup, GitHub uses a bunch of tricks like notification_referrer_id and other parameters to show that shelf if you are opening from the GitHub notifications page.

There's a lot of stuff in UI that is not available in API, and some stuff that we try to guess in this codebase.

The notification I received for this has notification_referrer_id as MDE4Ok5vdGlmaWNhdGlvblRocmVhZDE0MzgwMDQ5NDQ6Mzc3Njk5NzQ=, which decodes from base64 to 018:NotificationThread1438004944:37769974, a bunch of internal stuff that is not exposed in any way.

Also we don't have access to page content to do scraping :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants