Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is "sideEffects": false, necessary in the package.json of v3.0.0 #88

Closed
mavon80 opened this issue Sep 4, 2024 · 1 comment
Closed

Comments

@mavon80
Copy link

mavon80 commented Sep 4, 2024

With d726b58 you added "sideEffects": false, to the package.json

I use modern-normalize in my Storybook, just as documented in your readme as an import on top of the page, just like this:
import 'modern-normalize/modern-normalize.css'
But with this new config, tree shaking kicks it out again when i not set the import explicitly to a variable an use it, so i need to add a workaround in my code to really import it.

Not sure if i do something wrong but I don't get the new configuration.

@mavon80
Copy link
Author

mavon80 commented Sep 5, 2024

Thank you for the quick fix. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant