Change the default value of the cachePromiseRejection option to `tr…

…ue` (#36)
sindresorhus · May 17, 2019 · 70707ae · 70707ae
1 parent 10f13c0
commit 70707ae
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/index.d.ts b/index.d.ts
@@ -36,7 +36,7 @@ declare namespace mem {
 		/**
 		Cache rejected promises.
 
-		@default false
+		@default true
 		*/
 		readonly cachePromiseRejection?: boolean;
 	}

diff --git a/index.js b/index.js
@@ -26,7 +26,7 @@ const mem = (fn, options) => {
 	options = Object.assign({
 		cacheKey: defaultCacheKey,
 		cache: new Map(),
-		cachePromiseRejection: false
+		cachePromiseRejection: true
 	}, options);
 
 	if (typeof options.maxAge === 'number') {

diff --git a/readme.md b/readme.md
@@ -115,7 +115,7 @@ Use a different cache storage. Must implement the following methods: `.has(key)`
 ##### cachePromiseRejection
 
 Type: `boolean`<br>
-Default: `false`
+Default: `true`
 
 Cache rejected promises.
 

diff --git a/test.js b/test.js
@@ -162,7 +162,7 @@ test('promise support', async t => {
 	t.is(await memoized(10), 1);
 });
 
-test('do not cache rejected promises', async t => {
+test('cachePromiseRejection option', async t => {
 	let i = 0;
 	const memoized = mem(async () => {
 		i++;
@@ -172,6 +172,8 @@ test('do not cache rejected promises', async t => {
 		}
 
 		return i;
+	}, {
+		cachePromiseRejection: false
 	});
 
 	await t.throwsAsync(memoized(), 'foo bar');