-
-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check error instance for arguments test #2044
Check error instance for arguments test #2044
Conversation
Hey, @szmarczak is this PR fine for the issue mentioned? Please read description as I've only changed for a single test right now.. P.S. ignore all commits except latest one - those are from previous PR. Hope that one has no work left and can be merged? |
Please don't duplicate PRs, you need to wait until the previous one gets merged. |
Or, if the changes don't rely on the previous PR then you can remove those commits. |
Will remove those commits shortly. |
6a02490
to
80f4a57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it would be awesome if you could the TODOs mentioned above as well ❤️
Thanks a lot! 🥇 |
@szmarczak Hey. I'm looking to pick up some more tasks, maybe slightly more challenging. If there's any change in particular you'd like to be done for this repository, let me know and I'll take a look. That's if you don't mind and willing to help me out if needed. |
Sure, thanks for your interest! Here you go: #1462 |
Fixes #1087
First commit - I'd like verify that this is the expected change in the tests. Once that is done, will update in all the tests.
Checklist