Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check error instance for arguments test #2044

Merged

Conversation

IswaryaS
Copy link
Contributor

Fixes #1087

First commit - I'd like verify that this is the expected change in the tests. Once that is done, will update in all the tests.

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates in both the README and the types.

@IswaryaS
Copy link
Contributor Author

IswaryaS commented May 20, 2022

Hey, @szmarczak is this PR fine for the issue mentioned? Please read description as I've only changed for a single test right now..

P.S. ignore all commits except latest one - those are from previous PR. Hope that one has no work left and can be merged?

@szmarczak
Copy link
Collaborator

Please don't duplicate PRs, you need to wait until the previous one gets merged.

@szmarczak
Copy link
Collaborator

Or, if the changes don't rely on the previous PR then you can remove those commits.

@IswaryaS
Copy link
Contributor Author

Will remove those commits shortly.

@IswaryaS IswaryaS force-pushed the check-error-instance-for-arguments-test branch from 6a02490 to 80f4a57 Compare May 20, 2022 13:32
test/arguments.ts Outdated Show resolved Hide resolved
test/arguments.ts Outdated Show resolved Hide resolved
test/arguments.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@szmarczak szmarczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it would be awesome if you could the TODOs mentioned above as well ❤️

@szmarczak szmarczak merged commit 4cdcca3 into sindresorhus:main May 22, 2022
@szmarczak
Copy link
Collaborator

Thanks a lot! 🥇

@IswaryaS
Copy link
Contributor Author

@szmarczak Hey. I'm looking to pick up some more tasks, maybe slightly more challenging. If there's any change in particular you'd like to be done for this repository, let me know and I'll take a look. That's if you don't mind and willing to help me out if needed.

@szmarczak
Copy link
Collaborator

Sure, thanks for your interest! Here you go: #1462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check the type of error instances in tests
2 participants