Bun throws error 'A retry listener has been attached already'

[iamkhalidbashir]

Bun throws error on this line

https://github.com/sindresorhus/got/blob/944caa8ce8151d7b18ab17c4130b18d622c04ebe/source/core/index.ts#L219C3-L224C1

[sindresorhus]

If this only happens on Bun and not Node.js, you need to report it in the Bun issue tracker. They claim Node.js compatibility, so they need to resolve any Node.js compatibility issues.

[iamkhalidbashir]

It makes sense, you can close this if you'd like
but I think its a small fix as all of other packages dosent give an issue with bun
so if you could look into it, would appreciate it.

[erictheswift]

As I understand, issue is bun firing newListener event after listener have been added, while node fires when the listener is about to be added but not added yet.

fix is stuck oven-sh/bun#4395

[erictheswift]

Unfortunately this isn't the only thing where bun fails in got,
e.g. if I ditch the retry checker, then

    typedResponse.statusMessage = typedResponse.statusMessage ?? http.STATUS_CODES[statusCode];

throws

TypeError: Attempted to assign to readonly property.

also bun seems to freeze 2 times out of 3 not resolving a single request response forever — didn't dive deep into why )

[bryanjtc]

Does 1.0.13 fix the issue?

[Thinkscape]

Does 1.0.13 fix the issue?

nope :(

[prabhu]

With got 14.3.0, I am getting

767 |             const cacheRequest = cacheableStore.get(options.cache)(options, async (response) => {
768 |                 response._readableState.autoDestroy = false;
769 |                 if (request) {
770 |                     const fix = () => {
771 |                         if (response.req) {
772 |                             response.complete = response.req.res.complete;
                                                      ^
TypeError: undefined is not an object (evaluating 'response.req.res.complete')
      at fix (/home/runner/work/cdxgen/cdxgen/node_modules/got/dist/source/core/index.js:772:49)
      at /home/runner/work/cdxgen/cdxgen/node_modules/got/dist/source/core/index.js:776:21
      at /home/runner/work/cdxgen/cdxgen/node_modules/got/dist/source/core/index.js:767:84
      at /home/runner/work/cdxgen/cdxgen/node_modules/cacheable-request/dist/index.js:148:25
      at handler (/home/runner/work/cdxgen/cdxgen/node_modules/cacheable-request/dist/index.js:77:40)
      at node:http:930:191

[ibash]

fwiw after hitting this we just opted to use ky which is basically the same thing but works with fetch, so it works on bun.