From 7f4b30b2ef89f73279fb4ff95e5c38e9a0687181 Mon Sep 17 00:00:00 2001 From: Sindre Sorhus Date: Sun, 7 Jan 2024 22:34:51 +0700 Subject: [PATCH] Require Node.js 18 --- .github/workflows/main.yml | 3 +-- core.js | 4 ++-- package.json | 13 ++++++++----- test.js | 4 ++-- 4 files changed, 13 insertions(+), 11 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 31f93e98..346585cf 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -10,9 +10,8 @@ jobs: fail-fast: false matrix: node-version: + - 20 - 18 - - 16 - - 14 steps: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 diff --git a/core.js b/core.js index 63d68f05..34f4215a 100644 --- a/core.js +++ b/core.js @@ -1,6 +1,6 @@ import {Buffer} from 'node:buffer'; import * as Token from 'token-types'; -import * as strtok3 from 'strtok3/core'; // eslint-disable-line n/file-extension-in-import +import * as strtok3 from 'strtok3/core'; import { stringToBytes, tarHeaderChecksumMatches, @@ -794,7 +794,7 @@ export class FileTypeParser { const element = await readElement(); if (element.id === 0x42_82) { const rawValue = await tokenizer.readToken(new Token.StringType(element.len, 'utf-8')); - return rawValue.replace(/\00.*$/g, ''); // Return DocType + return rawValue.replaceAll(/\00.*$/g, ''); // Return DocType } await tokenizer.ignore(element.len); // ignore payload diff --git a/package.json b/package.json index ef4c6392..096cc879 100644 --- a/package.json +++ b/package.json @@ -20,7 +20,7 @@ }, "sideEffects": false, "engines": { - "node": ">=14.16" + "node": ">=18" }, "scripts": { "test": "xo && ava && tsd" @@ -216,18 +216,21 @@ }, "devDependencies": { "@tokenizer/token": "^0.3.0", - "@types/node": "^20.1.2", - "ava": "^5.2.0", + "@types/node": "^20.10.7", + "ava": "^6.0.1", "commonmark": "^0.30.0", "noop-stream": "^1.0.0", - "tsd": "^0.28.1", - "xo": "^0.54.2" + "tsd": "^0.30.3", + "xo": "^0.56.0" }, "xo": { "envs": [ "node", "browser" ], + "ignores": [ + "fixture" + ], "rules": { "no-inner-declarations": "warn", "no-await-in-loop": "warn", diff --git a/test.js b/test.js index 078d5a0b..db0e3a94 100644 --- a/test.js +++ b/test.js @@ -1,5 +1,5 @@ import process from 'node:process'; -import {Buffer, Blob} from 'node:buffer'; +import {Buffer} from 'node:buffer'; import path from 'node:path'; import {fileURLToPath} from 'node:url'; import fs from 'node:fs'; @@ -7,7 +7,7 @@ import stream from 'node:stream'; import test from 'ava'; import {readableNoopStream} from 'noop-stream'; import {Parser as ReadmeParser} from 'commonmark'; -import * as strtok3 from 'strtok3/core'; // eslint-disable-line n/file-extension-in-import +import * as strtok3 from 'strtok3/core'; import { fileTypeFromBuffer, fileTypeFromStream,