Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Node.js 8, add support for nano and Emacs, add TypeScript definition #6

Merged
merged 3 commits into from
Apr 18, 2019
Merged

Require Node.js 8, add support for nano and Emacs, add TypeScript definition #6

merged 3 commits into from
Apr 18, 2019

Conversation

BendingBender
Copy link
Contributor

@BendingBender BendingBender commented Apr 13, 2019

index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

I know you don't review the API thoroughly, but like I said before, if you see anything that could be improved in the API or otherwise, I'm all ears. Many of these modules I made years ago, and are not up to my current standards, documentation and API-wise.

@sindresorhus
Copy link
Owner

Thanks for adding additional editors ❤️

index.d.ts Outdated Show resolved Hide resolved
@BendingBender
Copy link
Contributor Author

I generally would avoid using default as a function name, it has this ambiguity with ES exports. What about renaming it to defaultEditor? Should we then rename the other two to getEditor and allEditors? What about named exports after renaming?

@sindresorhus
Copy link
Owner

What about renaming it to defaultEditor? Should we then rename the other two to getEditor and allEditors? What about named exports after renaming?

Yeah, we can rename all the methods and make them named exports.

@sindresorhus sindresorhus merged commit 9d1bd79 into sindresorhus:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants