Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon not showing #782

Closed
rosoau opened this issue Feb 13, 2019 · 13 comments
Closed

Icon not showing #782

rosoau opened this issue Feb 13, 2019 · 13 comments

Comments

@rosoau
Copy link

rosoau commented Feb 13, 2019

The application icon shows a blank icon.
The icon was installed into a very "unusual" location: /usr/share/icons/hicolor/0x0/apps/
I had never seen an icon folder called "0x0" before! Please keep to the established conventions!
the icon-cache updater somehow does not work on that location
putting a copy of the icon into the root icon folder: /usr/share/icons/
makes it show up in the menu without using the cache updater

@CvX
Copy link
Collaborator

CvX commented Feb 13, 2019

Caprine doesn’t do anything out of ordinary with its app icon. The issue you’re seeing could be a bug in electron-build.

@rosoau
Copy link
Author

rosoau commented Feb 19, 2019

Linux 4.15.0-45 Caprine 2.29.0
Electron stuffed up again on the Debian version
Icons are again in folder 0x0 which mathematically speaking is: Nothing times Nothing
It should have created icons in following sizes:
16x16 24x24 32x32 48x48 64x64 96x96 128x128 256x256 and 512x512
We need to keep an eye on Electron and act accordingly (correct mistakes)
Also the icon on your webpage and on caprine startup page have
not been modifed to your new design which is more roundish

@dusansimic
Copy link
Collaborator

This also happened on Ubuntu 18.10 Gnome 3.30.2. I use AppImage and icon doesn't show, just a default app icon.

@rosoau
Copy link
Author

rosoau commented Feb 20, 2019

I resized the new icon into following sizes:
16x16 24x24 32x32 48x48 64x64 96x96 128x128 256x256 and 512x512
and packed them into; caprine-icons.zip
dusansimic you can download the icons from here:
caprine-icons.zip
then copy the icon folders to their destinations
then do an icon update: sudo gtk-update-icon-cache /usr/share/icons/hicolor
and also: sudo update-icon-caches /usr/share/icons/hicolor
see if that works. I use the .deb file on Ubuntu 16.04

@elcanux
Copy link

elcanux commented Feb 21, 2019

I have also this bug on ubuntu 16.04 LTS with lastest version deb.
I have extract icons and that's works now, thanks

@dusansimic
Copy link
Collaborator

This method doesn't seem to work with AppImage.

@rosoau
Copy link
Author

rosoau commented Feb 21, 2019

Sorry dusansimic; I was afraid that it may not work with the appimage. If you allowed it to create a desktopfile then that file could be modified. It resides most likely in ~/.local/share/applications as: caprine.desktop. You can use one of the resized icons and point towards it on the line: Icon=
Like: Icon=/usr/share/icons/hicolor/32x32/apps/caprine.png
It is best to open the desktop file in the terminal: gedit ~/.local/share/applications/caprine.desktop
Instead of gedit use the name of your text-editor

@pols12
Copy link
Contributor

pols12 commented Feb 23, 2019

Seems to be electron-userland/electron-builder#2577 or electron-userland/electron-builder#3609 (see these issues to see workarounds). However the second one is older than Caprine v2.0.19 which worked properly for me.

@mquevill
Copy link
Collaborator

mquevill commented Jul 2, 2019

Issue still exists with the 2.33.1 .deb installed onto Linux Mint 19.1 with Cinnamon 4.0.10.

The only icon is located at /usr/share/icons/hicolor/0x0/apps/caprine.png. In fact, it's the only entry in the 0x0/ directory, which makes me think that something is going wrong with the .deb. packaging.

(But copying the files in the above caprine.zip works like a charm!)

@dusansimic
Copy link
Collaborator

I found a solution that works on latest Caprine (2.36) for AppImage. The problem is that when desktop file is generated automatically it sets icon to be appimagekit-caprine. Just change the icon variable to be caprine.

Usually the desktop file is located in .local/share/applications. For AppImage it'll be named appimagekit-caprine.desktop.

@keelnar
Copy link

keelnar commented Mar 29, 2020

Running into this issue with the 2.44.0 .deb on Ubuntu 18.04.4. It seems some folks have a workaround for this, but I'm unclear from this thread what the workaround is. Can anyone clarify?

@pols12
Copy link
Contributor

pols12 commented Mar 29, 2020

Running into this issue with the 2.44.0 .deb on Ubuntu 18.04.4. It seems some folks have a workaround for this, but I'm unclear from this thread what the workaround is. Can anyone clarify?

You can download rosoau’s icon file.
Then, extract it in your file system following archive-included hierarchy. (you have to consider the usr directory in the .zip matches with /usr).
Then execute both following command in a terminal as root (sudo them):

gtk-update-icon-cache /usr/share/icons/hicolor
update-icon-caches /usr/share/icons/hicolor

@dusansimic
Copy link
Collaborator

This issue is fixed now since icons of all sizes are included into the build. Just download the latest version of Caprine to have this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants