Call sound should also be disabled

[fregante]

The Sound is disabled in the settings, but I still hear the sound when I receive a call.

Calls also seem to be bypass the Desktop Notification setting.

Edit: This is not a Caprine bug but a Messenger "feature". Perhaps Caprine can fix it.

---

IssueHunt Summary

lukks has been rewarded.

Backers (Total: $50.00)

• issuehunt ($50.00)

Submitted pull Requests

• #1273 Call ringtone muted

---

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.

---

IssueHunt has been backed by the following sponsors. Become a sponsor

[piomar123]

What's your actual use case of this? Do you want to disable all the sounds or allow to have notification sounds but mute ringing only?

[fregante]

Disable all sounds, especially because the ringtone they chose is obnoxious.

[piomar123]

My current idea is to use setAudioMuted(true). It seems to work but if you want to actually answer or make a voice call, you need to disable the mute (it would be nice to detect it automatically).
You can find my draft here: https://github.com/piomar123/caprine/tree/209-disable-call-sound

[IssueHuntBot]

@IssueHunt has funded $50.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[whitecrownclown]

@piomar123 Wouldn't that disable all audio from the app? Including videos that you might want to play from a conversation. It would be cumbersome to toggle the option in order to watch a video with sound.

[piomar123]

@whitecrownclown Yes, it disables all audio. I wrote that in my comment up above - it should automatically detect playing videos and doing calls if this way of muting audio is chosen.

[fregante]

I think that doesn’t work if you’re watching a video and someone calls. It’s best to locate and deactivate the sound (block the HTTP or break the Web Audio API used)

[piomar123]

The question is what's easier - detecting incoming call and muting vs. blocking HTTP requests

[LuKks]

My pull request, as @fregante said, it will block the HTTP request for the call sound (there is a content-md5 header, in that way it find the sound), I also added an option to enable/disable the feature.

Due HTTP cache, for example, if the ringtone plays and now you disable it, the sound is already cached so you will need to restart the app.

[issuehunt-oss]

@sindresorhus has rewarded $45.00 to @lukks. See it on IssueHunt

• 💰 Total deposit: $50.00
• 🎉 Repository reward(0%): $0.00
• 🔧 Service fee(10%): $5.00