-
-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Colours not working #1531
Comments
Caprine 2.52.0 Dark Mode is working now but custom.css makes no difference |
It depends on what is in your custom.css file. The UI of messenger website is changed and thus any old custom styles should not be able to work. |
Actually, it seems the custom.css file might be loading in such a way that :root variables are being overridden. To work around #1525, I added in the CSS from here: https://github.com/cicerakes/DarkNight-FBMessenger But I couldn't get it to take effect unless I added !important to every single line in the :root definition. |
Sounds promising HugLifeTiZ. I got it to retain dark mode but not my custom colours. Could you please show us your custom.css? |
Sure thing. It's in this gist. |
@HugLifeTiZ it's very possible that you'd need to add The reason I mentioned the difference between old and new design is that your old CSS is not going to work on new design. Because whole Messenger CSS is redesigned, you'll need to change most of your custom CSS. I'd just like that everyone keeps that in mind. Don't expect anything from old design to "just work" because essentially Caprine is a wrapper for Messenger.com and thus when you get the new design, it's a different app in a sense that the HTML is completely different, CSS is completely different and we need to fix most of the features since they are broken by the redesign. |
This CSS is not for the old design, it's for the new design. Ferdi does not need an !important on every line for the variable changes to take effect. It's not a huge deal, but it may trip up people expecting it to work without that. |
Thanks heaps HugLifeTiZ. I changed text and background to my colours and I'm back again the way it looked before. Great. |
@HugLifeTiZ I've investigated a little bit. Seems like Ferdi injects css by creating a style tag in the page source and puts the user css in that style tag. Caprine injects css by using Electrons insertCSS function which won't create a style tag, rather somehow inject it directly into that window. I'm not completely sure how exactly it works but I can see that if css overrides some existing css and it is being injected by creating a style tag, it will override existing css. On the other hand, if injected css overrides some existing css and it's being injected using insertCSS function from Electron, then it will require I agree that it might create some problems for people that are not very skilled in CSS but i wouldn't change the way we insert css since this way we don't need to maintain the insertion mechanism, just call a function. A better solution would be to document this special case. Not in depth, just let people know that if they want to override some css they would probably need use |
Cool, thanks for the insight. That all sounds good to me. :) |
And the file itself: custom.css.rq0escxv.l9j0dhe7.du4w35lb.j83agx80.cbu4d94t.g5gj957u.d2edcug0.hpfvmrgz.kud993qy.buofh1pr { /* Scrollbar fixes. */ /* Dark theme from Ferdi user.css. / body { /* Delivered icon on left */ path[d="M0 36h36V0H0z"] { /* Icons */ .sp_o5t_XtHjhxN_1_5x { /* App download */ .sn0e7ne5 { /* Middle header */ /* Pop-up close icon */ /* Feedback icons */ /* Reacts */
|
This seems to be solved. I'll close it now. |
No description provided.
The text was updated successfully, but these errors were encountered: