Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track_files option counts every line as relevant #600

Closed
etki opened this issue Jul 24, 2017 · 4 comments
Closed

track_files option counts every line as relevant #600

etki opened this issue Jul 24, 2017 · 4 comments

Comments

@etki
Copy link

etki commented Jul 24, 2017

Hi!

It seems that files that are attached using track_files option are not analyzed for contents and relevant_lines count for those files is equal to lines count. This shouldn't bring any harm by itself, but in my case i have three accumulating test runs that upload their results to Coveralls - and because of that, at the end of the third run Coveralls thinks that i have 500 relevant lines more than i actually have and gives me 60% (while it is around 95% in reality).
I think i'll manage to create a fix on my side (by running Coveralls tool by hand)< but it would be wonderful if SimpleCov would provide such feature out-of-the-box.

@PragTob
Copy link
Collaborator

PragTob commented Jul 24, 2017

Thanks for the report!

That'd be... weird to go unnoticed so long. I hope it's something else. Iirc things that are added through track_files should just affect the files simplecov takes into account at all.

If you could provide a script to reproduce, that'd be wonderful in figuring this out. Otherwise I'd have to wip something up and time isn't exactly on my side right now :)

Also patches are of course very welcome!

@etki
Copy link
Author

etki commented Jul 24, 2017

@PragTob actually i think this is quite normal - the most probable option is that track_files only reads files, but doesn't require them, so it doesn't have information about relevant lines on hand. I'll try to reproduce this in a single repo when i can.

@odlp
Copy link
Contributor

odlp commented Aug 10, 2017

I think this will be fixed by #605

@PragTob
Copy link
Collaborator

PragTob commented Aug 12, 2017

Fixed by #605 🎉

@PragTob PragTob closed this as completed Aug 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants