Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement line number anchor #106

Merged
merged 3 commits into from
Oct 29, 2023

Conversation

nishidayuya
Copy link
Contributor

@nishidayuya nishidayuya commented Oct 11, 2020

This pull-request includes following:

  • Open path_to_coverage/index.html#<file_id>-L<linenumber> to display source code with scrolling to specified line number.
  • Make source code line as hyperlink to path_to_coverage/index.html#<file_id>-L<linenumber>.

Closes #49

@nishidayuya
Copy link
Contributor Author

Rebased from 7d1db36 (old master branch) to 3a30b47 (currently main branch)

This branch HEAD changed from 2d4a4aa to 07fb07d.

@nishidayuya nishidayuya force-pushed the anchor_for_line_number branch from 07fb07d to eecec23 Compare September 4, 2022 09:05
@nishidayuya
Copy link
Contributor Author

Rebased from 3a30b47 (old main branch) to 5bc5798 (currently main branch)

This branch HEAD changed from 07fb07d to eecec23.

@joshuapinter
Copy link
Contributor

This would be extremely helpful! Can we please get this reviewed and merged in?

The workflow of having to refresh the browser and scroll to the desired lines seems to be a common one.

Only thing that would make this better is the page auto refreshing when the coverage changes to reflect the coverage in real-time without any refreshes.

Thanks!

@joshuapinter
Copy link
Contributor

joshuapinter commented May 30, 2023

@nishidayuya Mate, I just merged your branch into our fork and this is so helpful. Makes adding tests and refreshing the existing index.html browser tab so much faster. Thank you for doing this.

Anybody landing here looking for a solution, I suggest using @nishidayuya's fork until this gets merged into main, which doesn't look like it will happen anytime soon. I'm still waiting for a PR of my own to get merged in: #117.

@amatsuda
Copy link
Member

This seems like a nice enhancement indeed. Thank you @jantman and @nishidayuya!

@amatsuda amatsuda merged commit 3fa764a into simplecov-ruby:main Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature proposal: line number anchors
3 participants