Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic tests for the HTMLBars plugin using the existing ember-cli infrastructure. The plugin is added to the dummy apps' registry so all
data-test-*
attributes within the dummy app are stripped. Then a normalmoduleForComponent
integration test adds assertions for successfully stripped attributes.Since the plugin itself is not located within
app/
ortests/
, the mocha JSHint test suite is setup to check for styling issues within the plugin.ember-try
is configured to run the tests using ember1.13
andcanary
,beta
as well asrelease
channels.The functionality of the HTMLBars plugin itself is fully tested now. One thing that still bugs me is that there is no test for the addon itself: since it adds the plugin only in the
production
environment, it would be nice to have a smoke test which basically does the following:I am not sure how this would be achieved yet, so this is still missing 😢
Closes #1