Use assert() for "read-only attributeBindings" warning
#254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
approved these changes
Oct 12, 2018
There was a problem hiding this comment.
This looks good to me 🎉
I understand what this is doing but I don't really understand the full context of the why this change is needed 🤔I see that you have marked this as breaking but I wonder if we have a process to write up a release notes snippet to explain why this has changed to our consumers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #205 and makes the warnings/error more consistent.
I'm marking this as a breaking change because it might cause previously succeeding builds to fail now. If the component has no
data-test-properties everything should still work fine though.