Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Babel version detection #131

Merged
merged 1 commit into from
Jul 11, 2017
Merged

Conversation

Turbo87
Copy link
Collaborator

@Turbo87 Turbo87 commented Jul 11, 2017

this obviously referred to the addon itself and this only worked before because ember-test-selectors itself does not depend on ember-cli-babel. Using this.parent instead will check the ember-cli-babel version of the parent (either addon or app) which is the correct behavior, even for using it as a nested addon.

Resolves #130

/cc @rwjblue

@Turbo87 Turbo87 added the bug label Jul 11, 2017
@Turbo87 Turbo87 requested a review from marcoow July 11, 2017 15:23
Copy link
Member

@marcoow marcoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this means we didn't have a test case for Babel 5, right? Can we add one?

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Jul 11, 2017

@marcoow we do have test cases for Babel 5, but as I said since ember-test-selectors is itself not depending on ember-cli-babel we would have gotten the correct version anyway. Writing a test for a situation where that is not the case is unfortunately unreasonably complex.

@marcoow marcoow merged commit 5dd7110 into mainmatter:master Jul 11, 2017
@Turbo87 Turbo87 deleted the fix-babel-detection branch July 11, 2017 16:08
@Turbo87
Copy link
Collaborator Author

Turbo87 commented Jul 11, 2017

Released as v0.3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants