Skip to content

Commit

Permalink
Ensure test selector stripping works for inline template compilation
Browse files Browse the repository at this point in the history
Prior to this, the `registry.add('htmlbars-ast-plugin', ...)` invocation in `index.js` runs _after_ all of the `htmlbars-ast-plugins` are read and registered for inline JS/TS compilation. It is still before stand alone templates are ran (and that is why it works for `*.hbs` files that are not colocation).

This ensures that `ember-test-selectors` runs _before_ `ember-cli-htmlbars` / `ember-cli-htmlbars-inline-precompile (so that we can ensure that `ember-test-selectors` included runs, and therefore the `htmlbars-ast-plugin` is registered before it is needed for inline template compilation).
  • Loading branch information
rwjblue authored and Turbo87 committed May 7, 2020
1 parent 3dd11fd commit 33ce230
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@
}
},
"ember-addon": {
"before": [
"ember-cli-htmlbars",
"ember-cli-htmlbars-inline-precompile"
],
"configPath": "tests/dummy/config",
"versionCompatibility": {
"ember": ">=3"
Expand Down

0 comments on commit 33ce230

Please sign in to comment.